Thread: Problem with Simple C Program

Originally Posted by djtomr941

This is what the code looks like now and it works, any other suggestions as far as good coding practice for C?

Yes, better to stay portable:

Code:

#include <stdio.h>
#include <ctype.h>

int main (void)
{
   int let = 0;
   int dig = 0;
   int other = 0;

   int c;

   while ((c = getchar ()) != '\n' && c != EOF)
   {
      if (isalpha (c))
      {
         ++let;
      }
      else if (isdigit (c))
      {
         ++dig;
      }
      else
      {
         ++other;
      }
   }

   printf ("%d letters, %d digits, %d others\n", let, dig, other);

   return 0;
}

Originally Posted by Kleid-0

But what makes it more portable? Is it not using:

Code:

isspace()

more portable because it only counts \n instead of \r\n?

There is no \r\n on a text stream (stdin, text file). The End Of Line character (EOL) is '\n', whatever the platform.

Code:

while ((c = getchar ()) != '\n' && c != EOF)

Is the EOF really that necessary? Because when the user hits enter, there has to be a \n, and thus that's all we need to quit the while loop.

Yes, because stdin can be redirected from a text file.

Originally Posted by Kleid-0

But in this case we wouldn't need to check for EOF because we're not using a text file for input, technically speaking?

Who knows ? It doesn't harm to leave the 'EOF' test and it makes the code more portable (ready for a file text entry)

$ myprog < myfile.txt

.

Originally Posted by djtomr941

What is the difference between these kinds of brackets ( ) and these kind { }.

The meaning (semantic) is different. The details belong to your C-book.

< isn't technically output (in fact, it's quite the opposite), but yes, it is cool