Thread: Some kind of memory mistake. Please review

Threaded View

Previous Post Previous Post   Next Post Next Post
  1. #1
    Registered User
    Join Date
    Nov 2004
    Posts
    4

    Some kind of memory mistake. Please review

    The following code runs fine for denom <= 11, but it gives a segmentation fault with the gcc compiler and doesn't run at all with other compilers for denom > 11. Please help! Thanks.

    Code:
    #include <stdio.h>
    
    
    void arrage(long *a, long *b);
    void reduce(long *numer, long *denom, long gcd);
    int getGCD(long a, long b);
    int getLCD(long a, long b);
    
    main()
    {
      long denom, lcd, sumNumer = 1, sumDenom = 1;
    
      for(denom = 2; denom <= 11; denom++) {
        lcd = getLCD(sumDenom, denom);
        sumNumer = sumNumer * lcd / sumDenom + lcd / denom;
        sumDenom = lcd;
        reduce(&sumNumer, &sumDenom, getGCD(sumDenom, sumNumer));
      }
      printf("Sum is: %d/%d or %.5f in decimal form.\n", 
    	 sumNumer, sumDenom, (double)sumNumer / sumDenom);
      getchar();
    }
    
    void arrage(long *a, long *b)
    {
      int temp;
      if(*b > *a) {
        temp = *a;
        *a = *b;
        *b = temp;
      }    
    }
    
    void reduce(long *numer, long *denom, long gcd)
    {
      *numer = *numer / gcd;
      *denom = *denom / gcd;
    }
    
    int getGCD(long a, long b)
    {
      int r;
      arrage(&a, &b);
      r = a % b;
      if(r == 0)
        return b;
      else
        return getGCD(b, r);
    }
    
    int getLCD(long a, long b)
    {
      return a * b / getGCD(a, b);
    }
    Last edited by mfantastique; 11-11-2004 at 09:48 PM.

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. tools for finding memory leaks
    By stanlvw in forum C++ Programming
    Replies: 4
    Last Post: 04-03-2009, 11:41 AM
  2. Help with insert/delete binary search tree
    By Nazgulled in forum C Programming
    Replies: 39
    Last Post: 03-25-2009, 04:24 PM
  3. Copying memory, pointers and the like.
    By psychopath in forum C++ Programming
    Replies: 34
    Last Post: 12-12-2006, 01:37 PM
  4. pointers
    By InvariantLoop in forum C Programming
    Replies: 13
    Last Post: 02-04-2005, 09:32 AM
  5. Im so lost at . .
    By hermit in forum C Programming
    Replies: 18
    Last Post: 05-15-2002, 01:26 AM