Thread: string reverse

i am unable to find the defect in the prog of string reverse without using a third varaible,

Code:

# include<stdio.h>
# include<conio.h>
# include<string.h>
void main()
{
char name[20];
int c1=0,c2;
clrscr();
printf("enter the string");
scanf("%s",name);
c2=strlen(name);
printf("\n %d \n",c2);
c2--;
for( ;c1++<c2--;)
{
name[c1]=name[c1]+name[c2];
name[c2]=name[c1]-name[c2];
name[c1]=name[c1]-name[c2];
}
printf("the reversed string \n");
printf("%s",name);
getch();
}

If i am giving input abc it is giving a,plz help me

To see whats going on, try this:

Code:

# include<stdio.h>
# include<conio.h>
# include<string.h>
void main()
{
char name[20];
int c1=0,c2;
clrscr();
printf("enter the string");
scanf("%s",name);
c2=strlen(name);
printf("\n %d \n",c2);
c2--;
printf("C1 = %d\tC2 = %d\n",c1,c2);
for( ;c1++<c2--;)
{
name[c1]=name[c1]+name[c2];
printf("Iteration 1: name[c1] = %d\t",name[c1]);
name[c2]=name[c1]-name[c2];
printf("name[c2] = %d\t",name[c2]);
name[c1]=name[c1]-name[c2];
printf("name[c1] = %d\n",name[c1]);
}
printf("Finally C1 = %d\t C2 = %d\n",c1,c2);
printf("the reversed string \n");
printf("%s",name);
getch();
}

Hope it makes your analysis clearer...

-Harsha

Originally Posted by vsriharsha

To see whats going on, try this:

Code:

# include<stdio.h>
# include<conio.h>
# include<string.h>
void main()
{
char name[20];
int c1=0,c2;
clrscr();
printf("enter the string");
scanf("%s",name);
c2=strlen(name);
printf("\n %d \n",c2);
c2--;
printf("C1 = %d\tC2 = %d\n",c1,c2);
for( ;c1++<c2--;)
{
name[c1]=name[c1]+name[c2];
printf("Iteration 1: name[c1] = %d\t",name[c1]);
name[c2]=name[c1]-name[c2];
printf("name[c2] = %d\t",name[c2]);
name[c1]=name[c1]-name[c2];
printf("name[c1] = %d\n",name[c1]);
}
printf("Finally C1 = %d\t C2 = %d\n",c1,c2);
printf("the reversed string \n");
printf("%s",name);
getch();
}

Hope it makes your analysis clearer...

-Harsha

Here are some additional points of interest:

1) The entirely unneeded, and non-standard <conio.h> header. Seriously, what's the point, when by typing 16 less characters, you can use getchar and have your program portable?

2) The incorrect declaration and usage of the main. Because as all good FAQ readers know, main returns an int.

3) The usage of scanf for reading strings, because as this FAQ entry shows, there are much nicer ways to get a line from the user.

4) And finally, what's the point of using [code] tags if you don't bother indenting?


Quzah.

> i am unable to find the defect in the prog of string reverse without using a third varaible,
Perhaps because there are half a dozen (or more defects)
In addition to those already mentioned

1. for( ;c1++<c2--
c1 and c2 change before you get to do any swapping of variables.

2. name[c1]=name[c1]+name[c2];
Since you don't know whether char is unsigned or signed, you have no way of knowing whether overflow in the addition will wrap around correctly, or invoke undefined behaviour.

Besides, swapping without a temporary ceased to be interesting when we stopped using assembler. All you end up doing is confusing either the reader or the compiler (or both)