Thread: what is wrong with this code

anyone can help?


#include<stdio.h>
#include<stdlib.h>
#include<string.h>

#define MAX 80
typedef char * STRNG;
char *code[MAX];

STRNG get_line(FILE * inf)
{
STRNG s;
char tok = getc(inf);
int count = 0;
s = malloc(80);
while(tok!='\n')
{
s[count++] = tok;
tok = getc(inf);
}
s[count] = '\0';
return s;
}

int main(int argc, char *argv[])
{
char* filename;
FILE *stream;
filename =argv[1];
int n=0;

stream=fopen(filename,"r");
if(stream ==NULL)
{ printf("Enter a valid parameter.Program will exit.\n");
exit(1);
}

code[n]=get_line(stream);

do{
n++;
}while(strlen(code[n])>1);
printf("%d\n",n);


return 1;
}

how am i suppose to do that?
sorry am very new in c
thanks

i changed my code in main into this:

int main(int argc, char *argv[])
{
FILE *stream;
stream=fopen(argv[1],"r");
if(stream ==NULL){
printf("Enter a valid parameter.Program will exit.\n");
exit(1);
}
else{
while(!feof(stream)){
code[n]=get_line(stream);
printf("%s\n",code[n]);
i++;

}
printf("%d\n",i);/*Here is the problem.I can't make it print out the final value */
}
any sugestions?
return 1;
}

#include<stdio.h>
#include<stdlib.h>
#include<string.h>

#define MAX 80
typedef char *STRNG;
char *code[MAX];

STRNG get_line(FILE *inf)
{
STRNG s;
char tok = getc(inf);
char *test = NULL;
int count = 0;
s = malloc(80);

test = &tok;

printf("Token is: %s\n", test);

while(tok!='\n')
{
printf ("\nCount is: %i %c", count, tok);

s[count++] = tok;
printf (" %i\n", count);
tok = getc(inf);
}
s[count] = '\0';
return s;
}


int main(int argc, char *argv[])
{
char* filename;
char *Ptr_String_NULL;
char Store_NULL = '\0';
FILE *stream;
int Index = 0;

/* You had declaration of int n=0 after */
/* filename assignment. */

int n=0;

filename =argv[1];

printf ("\nFilename is: \'%s\'\n", filename);
printf ("argc is: %i\n\n", argc);
stream=fopen(filename,"r");
if(stream ==NULL)
{
printf("Enter a valid parameter.Program will exit.\n");
exit(1);
}

/* Here is the thorn in your side. You need to always initialize
* every pointer in your array to NULL ( '\0' ) so that when you
* call 'strlen' it can determine the end of the string. strlen
* counts the characters in a string until it hits a '\0'. If
* it never runs into that "end of the string", it seg faults.
*/

Ptr_String_NULL = &Store_NULL;

for (Index = 0; Index < MAX; Index++)
{
code[Index] = Ptr_String_NULL;
}

/* You need to realize that you never increment n in this case
* and so the array of character pointers "code" will never have
* more than one element (char pointer). That pointer will always
* be for the first line of the file you passed to the function.
*/

/* another words, you are only assigning code[0] in this case */

code[n]=get_line(stream);


do
{
n++;
}while(strlen(code[n])>0);
printf("%d\n",n);



printf ("string is: %s\n", code[0]);

return 1;
}

It's that deja-vu feeling again...

http://www.cprogramming.com/cboard/s...&threadid=5622