Thread: WTF is going on here.

Ok.... I'm trying to get this program to work that is supposed to get ride of all unnecessary white space in a text file. But, it's not working can someone point me in the right direction.

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

int main(int argc, char *argv[])
{
FILE *in, *out;
int ch;
char name[80];
int count = 0;

if (argc < 2)
{
fprintf(stderr, "Usage: %s filename\n",argv[0]);
exit(1);
}

if ((in = fopen(argv[1], "r")) == NULL)
{
fprintf(stderr, "I couldn't open the file \"%s\"\n",argv[1]);
exit(2);
}

strcpy(name, argv[1]);
strcat(name, ".fnl");

if ((out = fopen(name, "w")) == NULL)
{
fprintf(stderr, "Can't create output fule.\n");
exit(3);
}

while ((ch = getc(in)) != EOF)

if (count++ != " " && ++(++count)) != " "))
putc(ch, out);

if (fclose(in) != 0 || fclose(out) != 0)
fprintf(stderr, "Error in closing files\n");
return 0;
}

Try this, instead of using a counter you use two reader variables, one to read the actual variable and one to test the next one and see if it's valid for the operation. Each time you read the whisker variable(whisker means it's feeling forward ), you test it for a space, if it's not space then you test it for EOF, if that's false too then you've got a valid character. Don't forget to ungetc() the whisker variable after that so that ch can read everything in order and you don't miss a character.

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

int main(int argc, char *argv[]){
	FILE *in, *out;
	int ch, chWhisker;
	char name[80];

	if (argc < 2){
		fprintf(stderr, "Usage: %s filename\n",argv[0]);
		exit(1);
	}

	if ((in = fopen(argv[1], "r")) == NULL){
		fprintf(stderr, "I couldn't open the file \"%s\"\n",argv[1]);
		exit(2);
	}

	strcpy(name, argv[1]);
	strcat(name, ".fnl");

	if ((out = fopen(name, "w")) == NULL){
		fprintf(stderr, "Can't create output fule.\n");
		exit(3);
	}

	while ((ch = getc(in)) != EOF){
		if (ch != " " && (((chWhisker = getc(in)) != " ") != EOF)){
			ungetc(chWhisker); 
			putc(ch, out);
		if (fclose(in) != NULL || fclose(out) != NULL)
			fprintf(stderr, "Error in closing files\n");
	}
	return 0;
}

> if (count++ != " " && (++(++count)) != " "))

Good god that's just wrong. Ok, it may be valid code, but it's fugly.

You cannot compare a single character with a string. 'count' is a single character for comparison sake. " " is a string containing a space and a null terminator.

Code:

while( (c=fgetc( inputFile )) != EOF )
{
    if( c == ' ' )
    {
        while( c==' ' && c != EOF ) c = fgetc( inputFile );
        if( c != ' ' ) ungetc( c, inputFile );
    }
}

How about something like that?

/** edit: you beat me to it! **/

Quzah.

God damnit. This is twice today it's signed me out while typing.
This should have an extra parenthesis:

> while( (c=fgetc(inputFile) != EOF ) printf("%c", c );

Should be:

while( (c=fgetc(inputFile)) != EOF ) printf("%c", c );

Quzah.