Sequential File Writing Error:

[Maragato]

Well I'm just practicing andsomething is wrong, compiler says nothing so I think it is a logical error.

//Creates a sequential write file

#include<stdio.h>

int
main ()
{

	int account;
	char name[30];
	float money;
	FILE *cfPtr;		//Client File Ptr

	if ((cfPtr = fopen ("client.dat", "w")) == NULL)
		printf ("Unable to open the file");
	else
	{
		printf ("Give an account numer, a name and the ammount of money");
		printf ("Give EOF to stop\n");
		scanf ("%d%s%f", &account, name, &money);

		while (!feof (stdin))
		{
			fprintf (cfPtr, "%d %s %.2f\n", account, name, money);
			printf ("?");
		scanf ("%d%s%f", &account, name, &money);}
		fclose (cfPtr);
	}
	return 0;
}

The program is writing the same register like 200000000000000000000000 into the output file, looks like I got some kind of loop.

[itsme86]

Read this thread to find out what (part of) your problem is:
http://cboard.cprogramming.com/showthread.php?t=55668

The linked-to thread has been active the last couple of days and I know you have to. Someone inexperienced can really learn a lot by reading other problems people are having. You should try it.

[Maragato]

Read this thread to find out what (part of) your problem is:
http://cboard.cprogramming.com/showthread.php?t=55668

The linked-to thread has been active the last couple of days and I know you have to. Someone inexperienced can really learn a lot by reading other problems people are having. You should try it.

Well thanks by the direction, anyway I still don't understanding what is wrong, it seem I need to flush the \n right? But on the post you pointed me ppl said it was supposed to enter a blank line, well I'm getting allways the same line. They suggested to fix it by adding a double getchar(); call, I've tried it and nothing happened... So I still kinda lost...

[Maragato]

Well thanks by the direction, anyway I still don't understanding what is wrong, it seem I need to flush the \n right? But on the post you pointed me ppl said it was supposed to enter a blank line, well I'm getting allways the same line. They suggested to fix it by adding a double getchar(); call, I've tried it and nothing happened... So I still kinda lost...

Oki I flushed the file so things seem to be working now:

//Creates a sequential write file

#include<stdio.h>

int main (){

	int account;
	char name[30];
	float money;
	FILE *cfPtr;		//Client File Ptr

	if ((cfPtr = fopen ("client.dat", "w")) == NULL)
		printf ("Unable to open the file");
	else {
		printf ("Give an account numer, a name and the ammount of money\n");
		printf ("Give EOF to stop\n");
		scanf ("%d%s%f", &account, name, &money);
	int	fflush(FILE *cfPtr);
		while (!feof(stdin)) 
		{
			fprintf (cfPtr, "%d %s %.2f\n", account, name, money);
			printf ("?");
		scanf ("%d%s%f", &account, name, &money);
		}
		fclose (cfPtr);
	}
	return 0;
}

it is getting the EOF, BUT not leaving the program at the end of the loop, suggestions?

[Salem]

The problem is with your use of scanf
As soon as you input an erroneous character, scanf will fail to make use of it, and since you do nothing to trap errors, the bad character will be there next time around the loop as well. Enter infinite loop here.

Try this and forget all about scanf

char buff[BUFSIZ];
while ( fgets( buff, BUFSIZ, stdin ) != NULL ) {
  if ( sscanf ( buff, "%d%s%f", &account, name, &money) == 3 ) {
    fprintf (cfPtr, "%d %s %.2f\n", account, name, money);
  } else {
    // error message
  }
}

[Maragato]

The problem is with your use of scanf
As soon as you input an erroneous character, scanf will fail to make use of it, and since you do nothing to trap errors, the bad character will be there next time around the loop as well. Enter infinite loop here.

Try this and forget all about scanf

char buff[BUFSIZ];
while ( fgets( buff, BUFSIZ, stdin ) != NULL ) {
  if ( sscanf ( buff, "%d%s%f", &account, name, &money) == 3 ) {
    fprintf (cfPtr, "%d %s %.2f\n", account, name, money);
  } else {
    // error message
  }
}

Ive tried this:

//Creates a sequential write file

#include<stdio.h>

int main ()
{
	char buff[BUFSIZ];
	int account;
	char name[30];
	float money;
	FILE *cfPtr;

	if ((cfPtr = fopen ("client.dat", "w")) == NULL)
		printf ("Unable to open the file");
	else
	{
		printf ("Give an account numer, a name and the ammount of money\n");
		printf ("Give EOF to stop\n");
		//scanf ("%d%s%f", &account, name, &money);
		//int fflush(FILE *cfPtr);

while (fgets (buff, BUFSIZ, stdin) != NULL)
	{
			if (sscanf (buff, "%d%s%f", &account, name, &money) ==
			    3)
			{
				fprintf (cfPtr, "%d %s %.2f\n", account, name,
					 money);
			}
			else
				printf ("ERROR!");



			while (!feof (stdin))
			{
				fprintf (cfPtr, "%d %s %.2f\n", account, name,
					 money);
				printf ("?");
				scanf ("%d%s%f", &account, name, &money);
			}
			fclose (cfPtr);
		}
	}
	return 0;
}

But I still with somekind of infinite loop, unable to leave the program...

And thx a lot for the tips about scanf.

[Salem]

So why do you still have that while (!feof (stdin))
I didn't need it - neither do you

[Maragato]

So why do you still have that while (!feof (stdin))
I didn't need it - neither do you

I have removed that crappy piece of code, but now I have seg fault when trying to insert the second record, but it is properly generating the file and inserting the first of the registers.

//Creates a sequential write file

#include<stdio.h>

int main ()
{
	char buff[BUFSIZ];
	int account;
	char name[30];
	float money;
	FILE *cfPtr;

	if ((cfPtr = fopen ("client.dat", "w")) == NULL)
		printf ("Unable to open the file");
	else
	{
		printf ("Give an account numer, a name and the ammount of money\n");
		printf ("Give EOF to stop\n");

while (fgets (buff, BUFSIZ, stdin) != NULL)
	{
			if (sscanf (buff, "%d%s%f", &account, name, &money) ==  3)
			{
				fprintf (cfPtr, "%d %s %.2f\n", account, name,
					 money);
			}
			else
				printf ("ERROR!");
		fclose (cfPtr);
		}
	}
	return 0;
}

Why thy hell I'm having seg fault?

[Emmanuel Delaha]

I have removed that crappy piece of code, but now I have seg fault when trying to insert the second record, but it is properly generating the file and inserting the first of the registers.
<...>
Why thy hell I'm having seg fault?

Try to reindent your code properly, and you will see that fclose() is not at the right place.

[Salem]

Decent indentation will save your life more times that you'll know.

#include<stdio.h>

int main()
{
    char buff[BUFSIZ];
    int account;
    char name[30];
    float money;
    FILE *cfPtr;

    if ((cfPtr = fopen("client.dat", "w")) == NULL)
        printf("Unable to open the file");
    else {
        printf("Give an account numer, a name and the ammount of money\n");
        printf("Give EOF to stop\n");

        while (fgets(buff, BUFSIZ, stdin) != NULL) {
            if (sscanf(buff, "%d%s%f", &account, name, &money) == 3) {
                fprintf(cfPtr, "%d %s %.2f\n", account, name, money);
            } else
                printf("ERROR!");
            fclose(cfPtr);
        }
    }
    return 0;
}

You close the file inside the while loop!!!!

[Maragato]

Decent indentation will save your life more times that you'll know.

#include<stdio.h>

int main()
{
    char buff[BUFSIZ];
    int account;
    char name[30];
    float money;
    FILE *cfPtr;

    if ((cfPtr = fopen("client.dat", "w")) == NULL)
        printf("Unable to open the file");
    else {
        printf("Give an account numer, a name and the ammount of money\n");
        printf("Give EOF to stop\n");

        while (fgets(buff, BUFSIZ, stdin) != NULL) {
            if (sscanf(buff, "%d%s%f", &account, name, &money) == 3) {
                fprintf(cfPtr, "%d %s %.2f\n", account, name, money);
            } else
                printf("ERROR!");
            fclose(cfPtr);
        }
    }
    return 0;
}

You close the file inside the while loop!!!!

All problems solved I love you guys!