Thread: Any Help Appreciated

>>if(len = strlen(p->name) > NAME_SZ)
How many equals signs needed to make a comparison?

>>char *filename;
>>scanf("%s", filename);
filename is a pointer, not an array. I'd suggest:
>>char filename[BUFSIZ];

In main():
>>if(size >= MAX)
What value does size have when you invoke this line of code? Think about it....

There are more things too, see how you get on....

If you want dynamic allocation, try:

Code:

char *filename;
filename = malloc(100);
scanf("%s", filename);

I've heard bad things about 'scanf()', the second line of code above will at least solve running into the end of an array.

{edit}

Originally Posted by loopy

If you want dynamic allocation, try:

Code:

char *filename;
*filename = malloc(100);
scanf("%s", filename);

I've heard bad things about 'scanf()', the second line of code above will at least solve running into the end of an array.

1) You're dereferencing filename, and are trying to assign the return of malloc there. That's wrong. Lose the first *. Because you're making an assignment to a pointer, not to what it dereferences to.

2) This eliminates running off the end of an array, true. But you can still blow by the end of your malloced memory. All I have to do is enter 101 characters without any white space and I've gone off the end.

The FAQ covers safer ways of getting input if anyone's interested.

Quzah.