The code below should take the user to the function 'f_main_menu ()' when they enter 'Nick' but instead the program just closes any ideas why?
Code:void f_enter_username () { char Owner[] = "Nick"; char buf[BUFSIZ]; printf ("\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\nEnter username: "); scanf("%s", Owner); fflush(stdout); if (fgets(buf, sizeof(buf), stdin)) { char *p = strchr(buf, '\n'); if (p) *p = '\0'; if (strcmp(Owner, buf) == 0) { f_main_menu (); } else return 0; }
I'm guessing you don't want this line:
scanf("%s", Owner);
Seeing as how the next few lines are for accepting user input. Try getting rid of it and see how the program works.
Are you sure that you are giving strcmp() the things you expect?
Why do you have scanf() for Owner?
Here's a suggestion:
put the following just before the line where you invoke strcmp()
Code:printf("Owner = <%s>\n", Owner); printf("buf = <%s>\n", buf);
printf() is your friend.
Dave
ive tried both but now when its compiling it says 'choice_i' undeclared', refering to the next function in the program.
> it says 'choice_i' undeclared', refering to the next function in the program.
Means nothing to us without you actually show your code.
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
when the user enters Nick they should be taken to f_main_menu_choice () but the compiler returns ''choice_i' undeclared'??
Code:void f_enter_username () { char Owner[] = "Nick"; char buf[BUFSIZ]; printf ("\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\nEnter username: "); fflush(stdout); if (fgets(buf, sizeof(buf), stdin)) { char *p = strchr(buf, '\n'); if (p) *p = '\0'; if (strcmp(Owner, buf) == 0) { f_main_menu_choice (); } else return 0; } /* ********************************************************* */ void f_main_menu_choice () { int choice_i; do { choice_i = f_main_menu (); switch ( choice_i ) { case 1 : f_designer_menu_choice (); break; case 2 : f_customer_menu_choice (); break; case 3 : printf ("************************************\n\n"); printf ("Thankyou for using this program\n\n"); printf ("Bye\n\n"); printf ("************************************\n\n"); break; } } while ( choice_i != 3 ); }
Count your braces ('{' and '}'). In the function you've posted you
haven't finished the function. This will cause all sorts of problems
in the next function.
The "else return 0" is pretty redundant too...
Try this:
Code:void f_enter_username () { char Owner[] = "Nick"; char buf[BUFSIZ]; printf ("\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\nEnter username: "); fflush(stdout); if (fgets(buf, sizeof(buf), stdin)) { char *p = strchr(buf, '\n'); if (p) *p = '\0'; if (strcmp(Owner, buf) == 0) { f_main_menu (); } // you only really need an else here if it's actually // doing something } // this was missing previously }
DavT
-----------------------------------------------
Great thanks thats sorted that out but now im back to my previous problem. It doesnt actually let me enter anything. the program just exits.
Code:{ char Owner[] = "Nick"; char buf[BUFSIZ]; printf ("\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\nEnter username: "); fflush(stdout); if (fgets(buf, sizeof(buf), stdin)) { char *p = strchr(buf, '\n'); if (p) *p = '\0'; if (strcmp(Owner, buf) == 0) { f_main_menu_choice (); } } }
Did you call scanf() at all before trying to call fgets() in this function?
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
Yes like in the first post but that didnt work.
Mixing scanf() and fgets() is a bad idea. scanf() just loves leaving ununsed characters on the input stream, mostly just newlines.
This is a problem, because fgets() uses newlines to mark the end of a line of input.
Which leads to
Kind of commentsCode:scanf( "%s", name ); fgets( buff, sizeof buff, stdin ); // this is skipped
Always (and exclusively) use fgets() for input, then deal with the buffer however you want.
Code:fgets( buff, sizeof buff, stdin ); sscanf( buff, "%s", name ); fgets( buff, sizeof buff, stdin );
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
Great thanks for that its working fine now.
