Thread: whats wrong with this?

>Hey everyone, spot the newbie
Too easy. Newbies always announce themselves as such for some strange reason. Probably a lack of confidence. We honestly don't care what your experience is as long as you don't act like a loser.

when this code comes back into the main part of the program the balance I imagine your description of the problem was supposed to go here, i was wondering why this is and whats going to be the best way to fix it?

>balance = deposited (deposit);
Deposit implies the amount to be added, not the current balance as the deposited function implies. This alone seems suspect.

>scanf ("%f", &deposit);
You should always check interactive input for success.

>balance = deposit + balance;
You change balance even when the value is out of range. Not good for keeping your promises.

>float bal = (balance);
Parentheses really aren't needed, but what is the point of the bal variable?

heh, yea you got me,

I've changed the code slightly since i posted this so:

The call:

Code:

case 1:
      printf ("1. Deposit funds \n");
      balance = deposited (balance, new_balance);
      break;

The actual function:

Code:

float deposited (float balance, float new_balance)
{ 
float deposit;
printf ("Please enter how much you wish to deposit \n");
scanf ("%f", &deposit);

      if ((deposit + balance < 999999) && (deposit + balance > 0))
      {

      new_balance = deposit + balance;
      printf ("Thank you %f has being entered into your account \n", deposit);
      printf ("Your current balance wibble = %f \n", &new_balance);
      }

      if ((deposit + balance > 999999) && (deposit + balance < 0))
      {
      printf ("I'm sorry but the number you have entered is either too large or too small/n");
      }

return (new_balance);
}

The problem is that it won't pass the result back into the main function meaning i can't use the value any further than the function, i need to pass the new_balance back.

Your code is still a little goofy. Without the use of pointers to modify your passed argument, it would be better simply to pass the balance, make the modifications, then return the modified balance and save the return of deposited to balance. Something more like this:

Code:

float deposited (float balance)
{ 
  float deposit;

  printf ("Please enter how much you wish to deposit \n");
  scanf ("%f", &deposit);
  if ((deposit + balance < 999999) && (deposit + balance > 0))
  {
    balance = balance + deposit;
    printf ("Thank you %.2f has been entered into your account\n", deposit);
    printf ("Your current balance wibble = %.2f\n", balance);
  }
  else
    printf ("I'm sorry but the number you have entered out of range/n");
  
  return (balance);
}

And you would call it like so:

Code:

balance = deposited (balance);

Now you can update balance if the deposit is within range, or refrain from updating balance otherwise with the same call to deposited. Which I imagine is what you wanted in the first place.

>printf ("Your current balance = %f \n", &balance);
You don't use the address operator when printing values. A type mismatch results in undefined behavior, but your compiler seems to prefer printing 0. Change the print to:

Code:

printf ("Your current balance = %f \n", balance);

and see what happens.

>if (transtype = 2)
You compare two values with ==, you assign a value with =. This is a sneaky error, so you have to watch out for it.

>does anyone know why i will always get an answer of 45 when i try to withdraw anything
I don't have this problem, your code seems to work correctly. Can you give us a detailed session that causes the problem as well as what compiler you use?

Turn up the warning level on your compiler.

Code:

#include <stdio.h>

float deposited (float);
float withdawn (float);
/* [Info 752] local declarator 'withdawn(float)' not referenced */

int main()
{
   int menu_choice = 0;
   float deposit = 0;
   float withdraw = 0;
   int transactions;
   float balance, new_balance;

   while ( menu_choice != 4 )
   {
      printf ("Your current balance = %.2f \n", balance);
/* [Warning 530] Symbol 'balance' not initialized */
      printf ("1.  Deposit funds \n");
      printf ("2.  Withdraw funds \n");
      printf ("3.  Show balance \n");
      printf ("4.  Quit Program \n");
      printf ("Please select what you wish to do (1-4): \n");
      scanf ("%d", &menu_choice);

      switch ( menu_choice )
      {
      case 1:
         printf ("1. Deposit funds \n");
         balance = deposited (balance);
         transactions ++;
/* [Warning 530] Symbol 'transactions' not initialized */
         break;

      case 2:
         printf ("2. Withdraw funds \n");
         balance = withdrawn (balance);
/* [Info 718] Symbol 'withdrawn' undeclared, assumed to return int */
/* [Info 746] call to function 'withdrawn()' not made in the presence of a prototype */
         break;

      case 3:
         printf ("3.  Show balance \n");
         printf ("Your current balance = %.2f \n", balance);
         break;

      case 4:
         printf ("Exiting... \n");
         break;

      default:
         printf("Please Enter a Choice from 1-4\n" );
         break;
      }

   }

   return 0;
/* [Warning 550] Symbol 'transactions' not accessed */
/* [Warning 529] Symbol 'deposit' not subsequently referenced */
/* [Warning 529] Symbol 'new_balance' not subsequently referenced */
/* [Warning 529] Symbol 'withdraw' not subsequently referenced */
}

float deposited (float balance)
{
   float deposit;

   printf ("Please enter how much you wish to deposit \n");
   scanf ("%f", &deposit);
   if ( (deposit + balance < 999999) || (deposit + balance > 0) )
   {
      balance = balance + deposit;
      printf ("Thank you %.2f has been entered into your account\n", deposit);
   }
   else
      printf ("I'm sorry but the number you have entered out of range/n");

   return(balance);
}

float withdrawn (float balance)
/* [Error 18] Symbol 'withdrawn()' redeclared (basic, Arg. no. 1: promotion) conflicts with line 37 */
/* [Warning 516] 'Symbol withdrawn(float)' has arg. type conflict (arg. no. 1 -- float vs. double) with line 37 */
{
   float withdraw = 0 ;
   int transtype;

   printf ("Please enter how you wish to withdraw \n");
   printf ("1.   Cash \n");
   printf ("2.   Cheque\n");
   scanf ("%d", &transtype);

   if ( transtype = 2 )
/* [Info 720] Boolean test of assignment */
/* [Warning 506] Constant value Boolean */
/* [Info 774] Boolean within 'if' always evaluates to True */
   {
      printf ("Please enter how a value up to a maximum of 500 \n");
      scanf ("%f", &withdraw);
      if ( withdraw > 500 )

         printf ("You are limited to a maximum of 500 \n");

      else

      {
         printf ("%.2f has being withdrawn from your account \n", withdraw);
         balance = balance - withdraw;
      }
   }
   return(balance);
}

>Damn thats alot of errors
Yet you haven't bothered to fix any of them.

>float balance, new_balance;
balance needs to have a value, 0 would be a good starting point.

>int transactions;
Ditto

>float withdawn (float);
This must be changed to

Code:

float withdrawn (float);

>fella


[edit]

Code:

float withdawn (float);
float withdrawn (float balance)

[/edit]

>its being compiled with Dev C++

You may want to add -Wall -ansi -pedantic to your compiler options.