Thread: do - while loop problem

hi every1

im doing a do - while loop in c and to check that either 1, 2, 3 or 4 is entered and to keep on asking for those numbers till one of them is entered (do-while checks for that).

the thing is the loop keeps on repeating even if one of those numbers is eneterd
my condition is

Code:

while(gameCh != 1 || gameCh != 2 || gameCh != 3 || gameCh != 4);

but when i just check for one number
eg

Code:

while(gameCh != 1)

the do while loop works - it exits when i enter 1
why doesnt it work for the four options?
could it be the multiple conditions in the first example?

The || has to be replaced with && as below,

Code:

while(gameCh != 1 && gameCh != 2 && gameCh != 3 && gameCh != 4);

Code:

while(gameCh != 1 || gameCh != 2 || gameCh != 3 || gameCh != 4);

is an infinite loop if gameCh is not any one of: 1,2,3,4

Code:

while(gameCh != 1 || gameCh != 2 || gameCh != 3 || gameCh != 4){


       // put an exit condtion here or set  gameCh =1;
}

Are you sure that the ';' isn't a typo? That would cause problems.

Look at the subject for this thread. When using a do while loop a semi colon has to be after the while.

Code:

do
  {
  /* code */
  }while ( /*conditions */ );

replacing || with && worked. thanx. and thanx to everyone else for their input.....