Error when running program

**cheeves** · 12-05-2003

Below is the code for my program. It does everything I want it to, but then at the end of running it an error appears. I can't figure out why it gives an error after doing everything I told it to successfully.

any help?

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#define N 100


main()

 {	
	int i,j,k,q=0;
	FILE *fp, *fp2;
	char s[N]={"\0"}, word2[N]={"\0"}, str[N]={"\0"}, file2word1[N]={"\0"}, file2word2[N]={"\0"};
	fp = fopen("check.out", "w");
	gets(s);
	fprintf(fp, "%s\n", str);
	printf("Line input has been added to check.out\n");
	fclose(fp);
	
	for(i=0; s[i]!='\0';i++)
		{	
			if(s[i]==' ')
				break;
		}
	for(j=i+1, k=0; s[j]!=' '; j++, k++)
		{
			word2[k]=s[j];
		}
	
	if(word2[0]=='\0')
		{
			printf("There is no second word in the input text.\nFile opening not tried.\n");
			q++;
			goto next;
		}
	
		if(q!=1)
		{
			if((fp2 = fopen(word2, "r")) == NULL)
		
			{
				printf("Tried opening file '%s'\nFile opening failed - file does not exist.\n", word2);
				q++;
			}
		}
	next:
	if(q!=1)
		{
		fp2=fopen(word2, "r");
	
		fscanf(fp2, "%s", &file2word1);
		fscanf(fp2, "%s", &file2word2);
		printf("Tried opening file '%s'\nFile opening successful - %s found and opened.\nSecond word in %s is '%s'", word2, word2, word2, file2word2);
		}
	
	return 0;
 }

**Prelude** · 12-05-2003

What error do you get? That can sometimes be helpful for finding the cause of the problem. Aside from ghastly programming style, the only real problems you should have at runtime (from a quick glance) is this:

Code:

fscanf(fp2, "%s", &file2word1);
fscanf(fp2, "%s", &file2word2);

Remove the address-of operators. The name of an array is already a pointer.

**cheeves** · 12-05-2003

Originally posted by Prelude
What error do you get? That can sometimes be helpful for finding the cause of the problem. Aside from ghastly programming style, the only real problems you should have at runtime (from a quick glance) is this:

Code:

fscanf(fp2, "%s", &file2word1); fscanf(fp2, "%s", &file2word2);

Remove the address-of operators. The name of an array is already a pointer.

It crashes.

**Dave_Sinkula** · 12-05-2003

Code:

PC-lint for C/C++ (NT) Ver. 8.00m, Copyright Gimpel Software 1985-2003

--- Module:   test.c
test.c 13: [Warning 534] Ignoring return value of function 'gets(char *)' (compare with line 179, file stdio.h)
test.c 13: [Warning 421] Caution -- function 'gets(char *)' is considered dangerous
test.c 14: [Warning 668] Possibly passing a null pointer to function 'fprintf(FILE *, const char *, ...)', arg. no. 1 [Reference: file test.c: line 12]
test.c 23: [Warning 661] Possible access of out-of-bounds pointer (1 beyond end of data) by operator '[' [Reference: file test.c: lines 18, 23]
test.c 25: [Warning 661] Possible access of out-of-bounds pointer (1 beyond end of data) by operator '[' [Reference: file test.c: lines 18, 23, 25]
test.c 23: [Warning 661] Possible access of out-of-bounds pointer (2 beyond end of data) by operator '[' [Reference: file test.c: lines 18, 23]
test.c 32: [Info 801] Use of goto is deprecated
test.c 48: [Warning 545] Suspicious use of &
test.c 48: [Warning 561] (arg. no. 3) indirect object inconsistent with format
test.c 48: [Warning 668] Possibly passing a null pointer to function 'fscanf(FILE *, const char *, ...)', arg. no. 1 [Reference: file test.c: line 46]
test.c 49: [Warning 545] Suspicious use of &
test.c 49: [Warning 561] (arg. no. 3) indirect object inconsistent with format
test.c 59: [Info 766] Header file 'stdlib.h' not used in module 'test.c'
test.c 59: [Info 766] Header file 'string.h' not used in module 'test.c'

**Draco** · 12-05-2003

I just ran the program and it ran fine as long as it could open the file

**Salem** · 12-05-2003

> gets(s);
> fprintf(fp, "%s\n", str);
So you read stuff into s, and print out the empty string str

Oh, and all those unchecked fopen() calls are a problem

Add some
if ( fp == NULL ) perror( "Cant open file" );

**jim mcnamara** · 12-05-2003

Dave S has a point - nobody seems to lint. Even the folks who know C here present samples (myself included) that don't test return codes, etc.

Thread: Error when running program

Thread Tools

Search Thread

Display

Error when running program

Similar Threads

Program running long

Running my program in the background

Trying to output to a directory other than the root of where the program is running

Why is my program running away?

Running program