Morse code conversion

**viclaster** · 12-04-2003

I am writing a program that will convert Morse code to alphabet and vice versa.

Here is the code so far

Code:

#include <stdio.h> 

int main() 
{
char *alpha[26] =
{
    "A",
    "B",
    "C",
    "D",
    "E",
    "F",
    "G",
    "H",
    "I",
    "J",
    "K",
    "L",
    "M",
    "N",
    "O",
    "P",
    "Q",
    "R",
    "S",
    "T",
    "U",
    "V",
    "W",
    "X",
    "Y",
    "Z",
};
char *morse[26] =
{
    ".-",
    "-...",
    "-.-.",
    "-..",
    ".",
    "..-.",
    "--.",
    "....",
    "..",
    ".---",
    ".-.-",
    ".-..",
    "--",
    "-.",
    "---",
    ".--.",
    "--.-",
    ".-.",
    "...",
    "-",
    "..-",
    "...-",
    ".--",
    "-..-",
    "-.--",
    "--..",
};
int w;


while( w != 3)
{
    w=0;
    printf("Please select an option\n");
    printf("1. Encode\n");
    printf("2. Decode\n");
    printf("3. Quit\n");
    scanf("%d", w);  
        if(w==1)
                printf("Encode\n");  //Encode function goes here
        else if(w==2)
                printf("Decode\n");   //Decode function goes here
        else
                printf("Wrong option selected\n");


}
}

This is just a test program and I haven't finished yet. But I get an error when I run the program. It gets to where you can select among the three options. When I select a number and hit enter I get
"(Name of File) has generated errors and will be closed by Windows. You will need to restart the program.

An error log is being created."

Does anyone know or see what I am doing wrong? Thanks for the help in advance.

**Thantos** · 12-04-2003

Code:

scanf("%d", w);

Should be

Code:

scanf("%d", &w);

**viclaster** · 12-04-2003

LOL, Thank you very much. Good eye. I have made that mistake many times in the past. I have probably overlooked that error 20 times just on this program. I'll have to be more careful. Thanks again.

**Salem** · 12-04-2003

> I'll have to be more careful
Or get a better compiler
Or just make better use of the options on the one you have

gcc -W -Wall -ansi prog.c
Catches an awful lot of trivial problems like this

**Thantos** · 12-04-2003

Hmmm good tips salem.

**WaltP** · 12-04-2003

Originally posted by Salem
> I'll have to be more careful
Or get a better compiler
Or just make better use of the options on the one you have

Or stop using scanf() and switch to fgets()

I had to get that in there

**Prelude** · 12-04-2003

>Or stop using scanf() and switch to fgets()
Assuming the desire to use integers instead of characters for the menu selection, sscanf would still be the most common option after fgets and you would end up with the same potential problem of not passing an address. Naturally you could do something like this:

Code:

if ( fgets ( buff, sizeof buff, stdin ) != NULL ) {
  switch ( buff[strspn ( buff, " \t" )] ) {
  case '1': /* Blah */
  case '2': /* Blah*/
  case '3': /* Blah*/
  }
}

But as usual, everyone and their immediate family would complain that there is a better way.

Thread: Morse code conversion

Thread Tools

Search Thread

Display

Morse code conversion

Similar Threads

Screwy Linker Error - VC2005

Seems like correct code, but results are not right...

About the Morse code Converter

Currency Conversion Program

Can you have nested code block? What does the compiler do? For example ...