Thread: Please I need Help with arrays

Go through the source and lay it out proplerly, then you'll see some obvious errors, like what's this doing:
>>double fnCurrencyConversion(...
It appears to be in the middle of the main function?!

Ok, I did a little bit of work cleaning some things up. The program will compile now, and I ran it and converted the Canadian dollar and it seems to do it ok. Did not really check it for errors if you enter an invalid number, but perhaps you can take it from here?

Code:

#include <stdio.h>

void menu(int*C);
double fnCurrencyConversion( int choice, double dollars, double conversion_rate[] );

int main (void)
{
	double conversion_rate[5]={1.48655, 1.166, 1.3469, 1.371, 6.5485};
	double dollars;
	double result;
	int choice;
	



	/* display menu */
	/* call function passing by reference */

	menu(&choice);
	/* display user selection */
	printf("Please enter dollar amount to convert:\n");
	scanf("%1lf", &dollars);
	
 	result=fnCurrencyConversion(choice, dollars, conversion_rate);
	printf("Results=$%.2f\n\n", result);
	getchar();
	/* terminates */
			
	return 0;	
}
	
       double fnCurrencyConversion(int choice, double dollars, double conversion_rate[])
	     {
		  double conversion;
	       
		  /* display user selection */
		  switch (choice){
        
		  case 1: /* Australian Dollar */
		       printf("You have selected the Australian dollar.\n");
		       conversion = dollars*conversion_rate[0]; /* Dollar amount is converted */
		       break;
	
		  case 2: /* Korean WON */
		       printf("You have selected the Korean (WON).\n");
		       conversion = dollars*conversion_rate[1]; /* Dollar amount is converted */
		       break;
	
		  case 3: /* Canadian Dollar */
		       printf("You have selected the Canadian dollar.\n");
		       conversion = dollars*conversion_rate[2]; /* Dollar amount is converted */
		       break;
	
		  case 4: /* Swiss Franc */
		       printf("You have selected the Swiss Franc.\n");
		       conversion = dollars*conversion_rate[3]; /* Dollar amount is converted */
		       break;
	
		  case 5: /* Danish Krane */
		       printf("You have selected the Danish Krane.\n");
		       conversion = dollars*conversion_rate[4]; /* Dollar amount is converted */
		       break;
		  }
		  return conversion; /* returns conversion rate */
	     }
	
       void menu(int*C)
            {

		 /* local variables for menu() */ 
		 int choice; 
	
                 /* show options to user */ 
		 printf("Currency Conversion\n"); /* Heading */
		 printf("This progran converts currency for a US dollar.\n"); /* Prints Topic */ 
		 printf("Enter a number to select currency.\n"); /* User enters a number that corresponds
								  * to the currency he/she wnats to convert 
								  */
		 printf("[1]-Australian (AUD)\n"); 
		 printf("[2]-South Korean (WON)\n"); 
		 printf("[3]-Canadian Dollar (CAD)\n"); 
		 printf("[4]-Swiss Franc (CHF)\n"); 
		 printf("[5]-Danish Krane (DKK)\n"); 
		 choice = 0; 
		 
		 while(choice < 1 || choice > 5){  /* If correct number is not entered, returns to selection */
			scanf("%d", &choice);  
			if (choice > 0 && choice <= 5 ){ 
			
                          /* true path */ 
			     printf("You selected a valid number, please continue.\n"); /*Correct number was entered */

			  /* conditional statement */ 
			}
			else{
 
			  /* false path */ 
			     printf("You didnt follow my instructions!\n"); /* User did not enter the correct number */

			  /* Prompts the user for a number */ 

			     printf("Please enter a valid number number ->"); /* Return statement because of 
									       * incorrect number entered 
									       */ 
			}
		
                          /* set value of referenced variable */ 
			*C = choice;
		

		 }
	    }

~/

Heh...I think that normally I have proven that I am far from greatest on this board. I am happy to have been of some help to you though. Actually, I kept playing with your code, and revised it a little to make the output a little nicer looking (I thought it looked nicer anyhow.)

edit: I am withdrawing the revised code, because it was stinky.

You might consider also looking into using something besides scanf to get user input, as there is no provision for error checking. A search on this board should provide you with the necessary information.