Thread: C program for creating player list

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#define MAX_PLAYERS 500
#define INPUT_FILE  "input.txt"

typedef struct {
  char name[20];
  char team[20];
  int  batting_avg;
} Cricket;

int read_players(Cricket *list)
{
  FILE *in;
  char *newline;
  int  i;

  if ((in = fopen(INPUT_FILE, "r")) == NULL)
    return -1;
  for (i = 0;; i++) {
    if (fgets(list[i].name, sizeof list[i].name, in) == NULL)
      break;
    if ((newline = strchr(list[i].name, '\n')) != NULL)
      *newline = '\0';
    if (fgets(list[i].team, sizeof list[i].team, in) == NULL)
      return -1;
    if ((newline = strchr(list[i].team, '\n')) != NULL)
      *newline = '\0';
    if (fscanf(in, "%d", &list[i].batting_avg) != 1)
      return -1;
    fgetc(in);
  }
  fclose(in);

  return i;
}

int cmp_name(const void *a, const void *b)
{
  return strcmp(((Cricket*)a)->name, ((Cricket*)b)->name);
}

int cmp_team(const void *a, const void *b)
{
  return strcmp(((Cricket*)a)->team, ((Cricket*)b)->team);
}

int cmp_avg(const void *a, const void *b)
{
  if (((Cricket*)a)->batting_avg > ((Cricket*)b)->batting_avg)
    return -1;
  else if (((Cricket*)a)->batting_avg < ((Cricket*)b)->batting_avg)
    return 1;
  else
    return 0;
}

int main(void)
{
  Cricket Player[MAX_PLAYERS];
  int    n;
  int    i;

  if ((n = read_players(Player)) != -1) {
    puts("SORT BY NAME");
    qsort(Player, n, sizeof Player[0], cmp_name);
    for (i = 0; i < n; i++) {
      printf("Player: %s\nTeam: %s\nBatting AVG: %d\n\n",
        Player[i].name, Player[i].team, Player[i].batting_avg);
    }
    puts("SORT BY TEAM");
    qsort(Player, n, sizeof Player[0], cmp_team);
    for (i = 0; i < n; i++) {
      printf("Player: %s\nTeam: %s\nBatting AVG: %d\n\n",
        Player[i].name, Player[i].team, Player[i].batting_avg);
    }
    puts("SORT BY BATTING AVG");
    qsort(Player, n, sizeof Player[0], cmp_avg);
    for (i = 0; i < n; i++) {
      printf("Player: %s\nTeam: %s\nBatting AVG: %d\n\n",
        Player[i].name, Player[i].team, Player[i].batting_avg);
    }
  }

  return 0;
}

Prelude, your from the US right? And I thought a Cricket question would have been the only thing you couldn't answer correctly, guess I was wrong!

>But unfortunatelly the code didn't work.
Then you didn't use it right, it works just fine for me.

>it is not accepting data from user.
It isn't supposed to. The program I posted reads from a file.

>Please check this problem.
>I need this program.
>Please help me.
This sounds a lot like you were expecting me to give you the the entire program so that you only had to turn it in. Since that would be wishful thinking, perhaps you should study the code I *did* give you and look for things that you can incorporate into your own program.

>>This sounds a lot like you were expecting me to give you the the entire program
Unfortunately, that's what you're going to get when you post a whole loada code in response to a "please help me" request.

Swapnil, we're here to help, show us you've made an attempt yourself, then people will be more willing to help you.

>Unfortunately, that's what you're going to get when you post a whole loada code in response to a "please help me" request.
I'll be sure to tag a comment to all code cut/paste compilable then:

Code:

/*
 * Disclaimer:
 *   All unique code supplied in this post is given as-is.
 *   The author of this program is not responsible for any
 *   errors, warnings, inconsistencies, or general lack of
 *   usefulness concerning the actual problem in question.
 *
 *   The following code is given as an example only. Any
 *   resemblance to the complete solution of the given
 *   problem is purely coincidence.
 */

>u have no right to make such statements!!!
Did a moderator add something that looked like a flame to my post when I wasn't looking? If I get reactions like this to polite posts then I won't bother taking the extra time to word my sentences so as not to insult anyone.

>but i had to choose different way of program as told by our professor!!
You didn't say how it was told by your professor, so I gave you the easiest solution. Be more specific and you'll get better help. And relax, you'll get an ulcer if you're always so high strung.

Obvious problems at a glance:

>void main()
Eew.

>gets(arr[i].name);
Eew!

>fflush(stdin);
*plonk*

The three most hated constructs around here are all bundled up in this one little program. Why are they hated? Well, void main is wrong, main must return an integer. The two correct variations are:

Code:

int main()

or

int main(void)

gets is just plain nasty, it opens all kinds of security holes and there's no way to make it safe. Use fgets instead. fflush is only defined for output streams, with input streams the behavior is unpredictable at best. And stdin is an input stream.

>>The three most hated constructs
... and it's not even in code tags