Thread: problem with letters

I have this code but it seems no matter what letter I choose it goes to if and not else:

Code:

void consonant()
{
	do
	{
		printf("Pick a letter: ");
			letter=getch();
		if (letter == 'a', 'e', 'i', 'o', 'u')
			printf("You can't pick a vowel choose again!!\n");
		else
			printf("\nYou choosed %c.\n\n", letter);
			valid = 1;
	}
	while(valid == 0);
	
	endturn = 0;
	winner = 0;
}

Thanks for the help

if (letter == 'a', 'e', 'i', 'o', 'u')

I don't think that's legal. You either have to say:

Code:

if (letter == 'a' || letter == 'e' || ...)

or you can write a macro or a function to do that for you:

Code:

#define is_vowel(x) ( x == 'a' || x == 'e' || x == 'i' ...)

if (is_vowel(letter)) ...

Originally posted by Salem
> I don't think that's legal. You either have to say:
Oh its quite legal - its just pretty useless - and almost certainly not what was wanted.
It basically degenerates into if ( 'u' != 0 )

Why exactly would it degenerate into that? I don't see why thatis the case, although I can see that the initial statement was wrong.