Thread: file reading problems

Declarations need to go at the top of a code block. So, it looks like this:

Code:

int foo(int i)
{
  FILE  *fp;
  /* Other  variable declarations here */
  /* Then the code */
  return something;
}

In C declarations must be at the beginning of a block.
[edit]
I definately need to decide faster what to type.
However, in JAVA you can declare a variable wherever you want.
[/edit]

Originally posted by Wledge
>>In C declarations must be at the beginning of a block.
Not in C99.
That's why gcc compiles without errors.

Yes, you're right. Before switching to gcc I used Borland. It truly does complain about declarations that are not at the beginning of a block. I guess that's why I have never tried it with gcc.

I got used to writing in both styles. I've never thought about which style is better. But if declaring variables right when you need them gives the compiler more information for optimizations (although I doubt that), then I would go for it regardless of bad (?) readability.

Originally posted by Speedy5
I think they should be declared right before they are used. That way if you have a 80-line function, you know which variables are used where. If you declare them all on the top, it might be harder to see what goes on when.

C++ allows local variable declarations anywhere you want.

I find it harder myself -- so I'm sure it completely depends on what you started learning on. In my case of course, C long before C99. I'm with you SourceCode.

I'd rather have the declarations at the top so I don't have to search the code for a declaration if I happen to notice a problem toward the end of the module.

Personally, I prefer them at the top of the code block, that way I know where to find them all easily, and I know the code will compile.

The only feature I really miss (as I don't generally code C99), is the ability to declare a loop variable in a for statement, like this:
>>for (int i = 0; i < 10; i++)
This is much neater way of doing things.

Sometimes, I declare variables within a specific block (ie, not at function level), just to keep things tidy. Like this:

Code:

void foo(void)
{
   /* lots of code here */

  if (i == 10)
  {
    int j;
    /* More code */
  }
  
}