Thread: Shorter notation?

Hi!

Anyone knows if this piece of code can be shorter?

Code:

// from left to right, than go up
	if ( ((ld->Char[Enemy->x+1][Enemy->y] == RIGHT_DOWN_LINE)      ||
		  (ld->Char[Enemy->x+1][Enemy->y] == RIGHT_UP_LINE)        ||
		  (ld->Char[Enemy->x+1][Enemy->y] == LEFT_DOWN_LINE)       ||
		  (ld->Char[Enemy->x+1][Enemy->y] == LEFT_UP_LINE)         ||
		  (ld->Char[Enemy->x+1][Enemy->y] == HORIZONTAL_LINE)      ||
		  (ld->Char[Enemy->x+1][Enemy->y] == HORIZONTAL_DOWN_LINE) ||
		  (ld->Char[Enemy->x+1][Enemy->y] == HORIZONTAL_UP_LINE)   ||
		  (ld->Char[Enemy->x+1][Enemy->y] == VERTICAL_LINE)        ||
		  (ld->Char[Enemy->x+1][Enemy->y] == VERTICAL_RIGHT_LINE)  ||
		  (ld->Char[Enemy->x+1][Enemy->y] == VERTICAL_LEFT_LINE)   ||
		  (ld->Char[Enemy->x+1][Enemy->y] == ALL_DIRECTION_LINE)) &&
		 ((ld->Char[Enemy->x][Enemy->y+1] != RIGHT_DOWN_LINE)      ||
		  (ld->Char[Enemy->x][Enemy->y+1] != RIGHT_UP_LINE)        ||
		  (ld->Char[Enemy->x][Enemy->y+1] != LEFT_DOWN_LINE)       ||
		  (ld->Char[Enemy->x][Enemy->y+1] != LEFT_UP_LINE)         ||
		  (ld->Char[Enemy->x][Enemy->y+1] != HORIZONTAL_LINE)      ||
		  (ld->Char[Enemy->x][Enemy->y+1] != HORIZONTAL_DOWN_LINE) ||
		  (ld->Char[Enemy->x][Enemy->y+1] != HORIZONTAL_UP_LINE)   ||
		  (ld->Char[Enemy->x][Enemy->y+1] != VERTICAL_LINE)        ||
		  (ld->Char[Enemy->x][Enemy->y+1] != VERTICAL_RIGHT_LINE)  ||
		  (ld->Char[Enemy->x][Enemy->y+1] != VERTICAL_LEFT_LINE)   ||
		  (ld->Char[Enemy->x][Enemy->y+1] != ALL_DIRECTION_LINE)) &&
		 ((ld->Char[Enemy->x][Enemy->y-1] != RIGHT_DOWN_LINE)      ||
		  (ld->Char[Enemy->x][Enemy->y-1] != RIGHT_UP_LINE)        ||
		  (ld->Char[Enemy->x][Enemy->y-1] != LEFT_DOWN_LINE)       ||
		  (ld->Char[Enemy->x][Enemy->y-1] != LEFT_UP_LINE)         ||
		  (ld->Char[Enemy->x][Enemy->y-1] != HORIZONTAL_LINE)      ||
		  (ld->Char[Enemy->x][Enemy->y-1] != HORIZONTAL_DOWN_LINE) ||
		  (ld->Char[Enemy->x][Enemy->y-1] != HORIZONTAL_UP_LINE)   ||
		  (ld->Char[Enemy->x][Enemy->y-1] != VERTICAL_LINE)        ||
		  (ld->Char[Enemy->x][Enemy->y-1] != VERTICAL_RIGHT_LINE)  ||
		  (ld->Char[Enemy->x][Enemy->y-1] != VERTICAL_LEFT_LINE)   ||
		  (ld->Char[Enemy->x][Enemy->y-1] != ALL_DIRECTION_LINE)) && (Enemy->DIRECTION.GoRight) )
	{
		Enemy->DIRECTION.GoDown  = FALSE;
		Enemy->DIRECTION.GoLeft  = FALSE;
		Enemy->DIRECTION.GoRight = FALSE;
		Enemy->DIRECTION.GoUp    = TRUE;
	}

Hmm. So I need to read the whole character map and mark the walls with the same value, right?

>From that I take it that the Char array is read directly from a file, and it contains chars like RIGHT_DOWN_LINE
Exactly.

>Yeah, I'd do a one-time scan of the Char array to build the Map array, to make life much easier in the rest of the code.

I just coded that.


THANK YOU SALEM!!!