Thread: What's Wrong With My Code?

Code:

#include <stdio.h>

struct names
	{
		char name [20];
		int cars ;
		int planes ;
	} person[6];

int main()
{

	printf("Please enter name, number of cars, & number of planes.\n");

	for(int i=0; i<=5; i++)
	{
		scanf( "%s", person[i].name);
		scanf( "%d", &person[i].cars);
		scanf( "%d", &person[i].planes);
	}

	for( i=0; i<=5; i++)
	{
		printf("Mr/Ms %s has %d and %d \n", person[i].name, person[i].cars, person[i].planes);
	}

	return 0;
}

Let's see now:
Structures are intermediate so $10
But, many of your mistakes are beginner so $5
But, because you really murdered the C language i want $1000 ( not only for me, but for C's pride... )
See my price list for further details

Ouu....!!!
Never use i for an array, that's italic..

Code:

#include <stdio.h>

struct names
	{
		char name [20];
		int cars ;
		int planes ;
	} person[6];

int main()
{

	printf("Please enter name, number of cars, & number of planes.\n");

	for(int j=0; j<=5; j++)
	{
		scanf( "%s", person[j].name);
		scanf( "%d", &person[j].cars);
		scanf( "%d", &person[j].planes);
	}

	for( j=0; j<=5; j++)
	{
		printf("Mr/Ms %s has %d and %d \n", person[j].name, person[j].cars, person[j].planes);
	}

	return 0;
}

Don't forget my money !

>having problems understanding pointers..
How did you proceed to structures without understanding pointers?

Sure... I agree with you, but because all tutorials i have seen introduce pointers at first and then go to structures, i guessed that he would know to use pointers before structures.

You don't need to know pointers before learning to work with structures. Since pointers are such an important concept in C and C++, books often treat them in one of the first chapters.

Using the combination of pointers and structs you can create datatypes like stacks, trees, graphs and many others.

Well... i have a/some suggestion/s for you javacvb.
Leave the structures aside and go back to the pointers. Learn very good the pointers and then come again to structures. I think that a nice hint is not to leave something unfinished. BE PROFESSINAL. Whatever you do, do it perfect. Find some good exercises that might help you with pointers. I used to have some problems with pointers, but now i see that they are not that difficult. And one day you will say the same. If you still have problems, this forum is always open for you ( i guess so ).
You gave me the sense that you are trying to learn C in a day, and that time chases you. And as a result, you try to learn many many things - only the basics ( that's wrong ) - so fast and in conclusion you know nothing! Always remember that smattering is worst than ignorance. That's the way to top!
So, finish pointers and then go on. Take your time with structures and then procceed to stacks & queues. Meanwhile solve some exercises.

Eeeer... I wish you good luck...and hard performance ( take it as entertaining performance ).

I agree with AProg. Take the time to learn the language and learn how to apply the language well. Don't just learn about the language features, but especially how to apply them and how you shouldn't apply them. Before learning concepts like stacks, queues and other datastructures, you should understand the underlying concepts, like pointers and structures, to be able to really understand how datastructures work and to be able to apply them well.