Thread: Merging files (code included)

> fscanf(report_fp, "%d %s %d %f", &report_code, &str_1, &number_in_stock,
&total_price_in_stock);

Before you do this, you need to close the file, and open it for reading

> 1) When there is a space in the item name the str stops copying/moving.
Because "%s" stops scanning at the first space.
I'm assuming that no digits will appear in the description, in which case,
fscanf(inventry_fp, "%s %d %s %f"
should be
fscanf(inventry_fp, "%[^0-9]%d %s %f"

What this means is treat the first field as consisting of any characters which are not digits.

This is how you should be reading each line - fscanf is pretty poor

Code:

    char buff[BUFSIZ];
    while ( fgets( buff, BUFSIZ, inventry_fp) != NULL ) {
        int res = sscanf( buff, "%[^0-9]%d %s %f",
            str_1, &inventry_code,   // you don't need & for arrays
            str_2, &price_per_item );
        if ( res != 4 ) {
            // error - did not convert all the expected values
        }
    }

> char str_1 [12];
> char str_2 [2];
These strings are not large enough.
Remember strings have a trailing \0 to mark the end of the string.

> It comes on the 2nd char buff[BUFSIZ] line.
Because now you're writing C++
In C, all variables must be declared at the start of the block.

In this case, the 2nd declaration of buff is unnecessary - just delete it.

The code should be

Code:

while (fgets(buff, BUFSIZ, inventry_fp) != NULL)
{
    int res = sscanf(buff, "%[^0-9] %d %s %f", str_1, 
        &inventry_code, str_2, &price_per_item);
    if(res != 4)
    {
        printf("Error - did not convert all the expected values!");
    }

    // you only want to read one line from this file
    // to match the single line from the other file
    if (fgets(buff, BUFSIZ, instock_fp) != NULL)
    {
        int res = sscanf(buff, "%d %d", &number_in_stock, &instock_code);
        if(res != 2)
        {
            printf("Error - did not convert all the expected values!");
        }
    }

    if (inventry_code == instock_code)
    {
        total_price_in_stock = number_in_stock * price_per_item;
        report_code = instock_code;
        fprintf(report_fp, "%d %s %d %f", report_code, str_1, 
            number_in_stock, total_price_in_stock);
    }
    else
        fprintf(stderr, "Inventry Code of: %d does not match instock_code of: %d\n",
                    inventry_code, instock_code);
}