Inputing values

**blindleaf** · 05-07-2003

ok look i want to input something like this:

Yellow_Card
Blue_Dress
Orange_Hat
Purple_Noodle
Green_Fan
Lovely_Sam
Cheesy_Freddy
Marketing_Mark
Formula_One
####

and the "####" signals the end of what is supposed to be input, i want to store these names in the name field of a structure called Dealers:

Code:

typedef struct{
	char name[21];
	int num_cars;
	int num_people;
	Model quantity[4];
	Salesperson employees[8];
    } Dealer;

void init_dealers(Dealer *); 

main()
{
	int i;
	Dealer dealers[10];
	
	init_dealers(&dealers);
	
	for(i=0; i<10; i++)
		printf("%s", dealers[i].name);
	
	
	return 0;
}

void init_dealers(Dealer *dealer)
{
	int end=1;
	while(end)
	{
		scanf("%s", dealer->name);
		dealer++;
		if(strcmp(dealer->name, "####"))
			end=0;	
	}	
}

whats wrong with my code?

**serruya** · 05-07-2003

>init_dealers(&dealers);
remove the '&'

And strcmp just return 0 when the strings are the same... so change to if(!strcmp...) or if(strcmp(.....) == 0)

**blindleaf** · 05-07-2003

ok here's the code now, and the errors that are with it:

Code:

#include <stdio.h>
#include <string.h>
#include <ctype.h>

typedef struct{
        long id;
        float quota;
        float sales_credit;
    } Salesperson;

typedef struct{
        char trim[3];
        char color[21];
        float retail;
        float invoice;
    } Car;

typedef struct{
        char name[21];
        int in_stock;
        Car cars[10];
    } Model;

typedef struct{
        char name[21];
        int num_cars;
        int num_people;
        Model quantity[4];
        Salesperson employees[8];
    } Dealer;

void init_dealers(Dealer *d);
void stock_car();
void hire_salesperson();
void sell_car();
void find_car();
void car_match();
void deliver_car();
void print_report();

main()
{
        int i;
        Dealer dealers[10];

        init_dealers(dealers);

        for(i=0; i<10; i++)
                printf("%s", dealers.name);

        return 0;
}

void init_dealers(Dealer *d)
{
        int end=1;
        while(end)
        {
                scanf("%s", &d->name);
                dealer++;
                if(!strcmp(d->name, "####"))
                        end=0;
        }
}

Code:

cc: Error: p7.c, line 60: In this statement, "dealers" has a pointer type, but occur
s in a context that requires a union or struct. (needstruct)
                printf("%s", dealers.name);
-----------------------------^
cc: Error: p7.c, line 71: In this statement, "dealer" is not declared. (undeclared)
                dealer++;
----------------^

what is going on here? and what am i missing?

**serruya** · 05-07-2003

> for(i=0; i<10; i++)
printf("%s", dealers.name);
you want to print the same name always? maybe dealers[i].name?

>>Dealer *d .... dealer++;
you know the problem? what the hell is dealer++ it's a type, not the variable, maybe d++?

**blindleaf** · 05-07-2003

ok i changed that but i dont know how to make it stop once it gets to "####" the code i have now isn't doing that, please can someone help?

**serruya** · 05-07-2003

the d++ should be after the checking! not before...

Code:

#include <stdio.h>
#include <string.h>
#include <ctype.h>

typedef struct{
        long id;
        float quota;
        float sales_credit;
    } Salesperson;

typedef struct{
        char trim[3];
        char color[21];
        float retail;
        float invoice;
    } Car;

typedef struct{
        char name[21];
        int in_stock;
        Car cars[10];
    } Model;

typedef struct{
        char name[21];
        int num_cars;
        int num_people;
        Model quantity[4];
        Salesperson employees[8];
    } Dealer;

void init_dealers(Dealer *d);
void stock_car();
void hire_salesperson();
void sell_car();
void find_car();
void car_match();
void deliver_car();
void print_report();

main()
{
        int i;
        Dealer dealers[10];

        init_dealers(dealers);

        for(i=0; i<10; i++)
                printf("%s", dealers[i].name);

        return 0;
}

void init_dealers(Dealer *d)
{
        int end=1;
        while(end)
        {
                scanf("%s", d->name);
                if(!strcmp(d->name, "####"))
                      end=0;
                 d++;
        }
}

**blindleaf** · 05-07-2003

Crap here's my output:

Code:

€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ
€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ
€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ
€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ
€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ
€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ
€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ€õÿ

what the hell is wrong now?

**Hammer** · 05-07-2003

What does your code look like now?

Also:
>>void init_dealers(Dealer *d)
>>d++;
This is a sure case for a buffer overflow in the future. You do best by passing in the number of elements in the dealer array, and ensuring that you don't load more than that number into it.

**blindleaf** · 05-07-2003

here's my code now:

Code:

#include <stdio.h>
#include <string.h>
#include <ctype.h>

typedef struct{
	long id;
	float quota;
	float sales_credit;
    } Salesperson;

typedef struct{
	char trim[3];
	char color[21];
	float retail;
	float invoice;
    } Car;

typedef struct{
	char name[21];
	int in_stock;
	Car cars[10];
    } Model;        

typedef struct{
	char name[21];
	int num_cars;
	int num_people;
	Model quantity[4];
	Salesperson employees[8];
    } Dealer;
    
void init_dealers(Dealer *d); 
void stock_car();
void hire_salesperson(); 
void sell_car();
void find_car(); 
void car_match(); 
void deliver_car(); 
void print_report(); 

main()
{
	int i;
	Dealer dealers[10];
	
	init_dealers(dealers);
	
	for(i=0; i<10; i++)
		printf("%s", dealers[i].name);
		
	return 0;
}

void init_dealers(Dealer *d)
{
	int end=1;
	while(end)
	{
		scanf("%s", d->name);
		
		if(strstr(d->name, "####"))
			end=0;	
	    d++;
	}	
}

**Hammer** · 05-07-2003

Using your original input, here's the output I get:

Code:

Yellow_CardBlue_DressOrange_HatPurple_NoodleGreen_FanLovely_SamCheesy_FreddyMark
eting_MarkFormula_One####

(It's actually all on one line)

What is the problem again?

**quzah** · 05-07-2003

Code:

void init_dealers(Dealer *d)
{
	int end=1;
	while(end)
	{
		scanf("%s", d->name);
		
		if(strstr(d->name, "####"))
			end=0;	
	    d++;
	}	
}

Eh. That's definately not the preferred method of doing this.

For starters, your 'end' variable isn't really needed. You can just use "break;" instead of your "end=0;" line.

Next, you should really be checking the return value of scanf if you're going to use it.

You should really be using something like fscanf so I don't blow past the end of your array.

Furthermore, as already suggested, you should be passing the number of elements so I don't blow past the end of your structure array by entering more than 10 values.

In short, your program gets the "highly crashable" rating. The ony thing off hand I could see to make it worse, would be to use gets to really deserve the 'amazingly crashable' rating.

Quzah.

Thread: Inputing values

Thread Tools

Search Thread

Display

Inputing values

Similar Threads

putting values into an array

Please help me to convert a simple C++ program into an object-oriented one.

Need help with project

Struct Values

i fail to call values of structure variable in another function