Thread: Character Array - almost? works

trying to creat a program that reads characters one at a time. An array is created to hold Unique characters. If a character already has been entered into the array, it is not entered again. My problem with this is in the for loop. The way i have the condition set up is so that is checks the partially filled array but also checks the next element which is never filled.

Anyway, Here's what its supposed to do:

Enter up to 20 unique characters:

The authors are Jeri Hanly and Elliot D. Koffman

output: TheautorsJiHnlydED.K

I have two files - a driver and a function to be called - here is the code:

MAIN function

Code:

#define SIZE 20

void add_char(char A[], char ch, int *count);

main()
{
	char character;
	char ary[SIZE];
	int count;
	int i;

	printf("Enter up to 20 unique characters; "
		"quit with 2 control-Ds:\n");

        scanf(" %c", &character);

	count = 0;

	while(count < SIZE)
	{
		add_char(ary, character, &count);
                scanf(" %c", &character); 
	}

	printf("\n");
        
	for (i = 0; i < count; ++i)
	{
		printf("%c", ary[i]);
	}
	printf("\n\n");
}

ADD_CHAR function

Code:

void add_char(char A[], char ch, int *count)
{
	int i, add;
	
	add = 0;

	printf("test for char: %c \n", ch);

	for(i = 0; i <= *count; ++i)
	{
		if (A[i] == ch)
		{
		}
		else
		{
			add = 1;
		}
	}

	if (add == 1)
	{
		A[*count] = ch;
		++(*count);
	}
}

I'm not sure, but, try something like that:

Code:

#include <stdio.h>
#include <stdlib.h>


int exist (char *str, char c) {
    while (*str++)
        if (*str == c)
           return 1;
    
    return 0;
}

void add (char *str, char c,int *tmp) {
     int i;
     
     for (i=0; i<(*tmp); ++i)
        ;
     str[i] = c;
}

int main(void)
{
    char str[100];
    char curr;
    int tmp = 0;
    
    while ((curr = getchar()) != '\n')
       if (!exist(str,curr)) {
          add(str,curr,&tmp);
          tmp++;
       }
    str[tmp] = '\0';
    
    printf("The result: %s\n",str);
    system("PAUSE");
    return 0;
}

Sorry about the code, he is messy, but it will give you an idea.
good luck.

thanks, but i'd really like to know how to use a for loop to test

A for loop to test exactly what? If a specified char is in your string?