Thread: What am I doing wrong?

When I compile this part of my program it will complie correctly, but when I run the program it always crashes. I have narrowed it down to the prinf statement right after I scan in the files. What am I doing wrong here?
(I din't include the rest of the program because my problem lie's within this area)

Code:

#include <stdio.h>


char lname[20], fname[15], phoneNo[12];
int menuchoice, record, cnt, totalcnt;
FILE *infile, *outfile;


	struct record{
			char lname[20];
			char fname[15];
			char phoneNo[12];
	};


int menu(struct record phonebook, int);
void addrecord(struct record phonebook, int);
void deleterecord(struct record phonebook, int);
void editrecord(struct record phonebook, int);
void search(struct record phonebook, int);
void view(struct record phonebook, int);
void sort(struct record phonebook, int);




int main (void)
{

struct record phonebook;
char filename[20];

printf("\n\nEnter file name to open: ");
scanf("%s", &filename);
infile=fopen(filename,"r");
if (infile == NULL){printf("Unable to open file");return(0);}


while(fscanf(infile, "%s %s %s", &phonebook.lname[cnt], &phonebook.fname[cnt], &phonebook.phoneNo[cnt]) != EOF) cnt++;
printf("%s %s %s", phonebook.lname[0], phonebook.fname[0], phonebook.phoneNo[0]);

totalcnt = cnt;;

return 0;
}

//char filename[20];
You should give more space.. char filename[50]; will be fine

//scanf("%s", &filename);
use fgets() to collect strings from streams

You cannot give as input something like that:

Code:

c:\programming\file.out

You need to double '\', look:

Code:

c:\\programming\\file.out

I have a txt file that includes this in it:

Young John 4073823481
Brown Fred 2738230116

I also have it stored in the same directory so when I open it I only have to do is type data.txt and it will open the file... I am still getting an error.. I have attached the ziped file of all the code and the data file and the compiled program so you can see what I mean.

You have a lot of bugs in your code.
About your file that won't work, look here:

Code:

char filename[50];

printf("\n\nEnter file name to open: ");
scanf("%s", &filename);
if((infile = fopen(filename, "r")) == NULL) {
    perror("Could not open the file\n");
        exit(1);
}

This should work fine, try input like that:

Code:

c:\data.txt
or
c:\\data.txt

Now, what you mean here?

Code:

phonebook.lname[0] = "Banks";
phonebook.fname[0] = "John";
phonebook.phoneNo[0] = "885-0983";

someone once in the forum told me to do this...
and for me it work's at least, something wrong with that?

I tried again and both / and // works here.

oops...

--------------------------------------------------------------------------------
phonebook.lname[0] = "Banks";
phonebook.fname[0] = "John";
phonebook.phoneNo[0] = "885-0983";

was a test and one of the last times I saved it.. that isn't in the real program. I am not having a problem with the scanning as much as I am when I print it. Unless the scanning is the error. I removed the printf statement right after the scaning part and the program ran correctly till I tried to print out the values that I scaned in. I still recieved this error when I programed in the values of the structures. like you see above. So what is wrong with my structure's or my printing?

You got a lot of serious errors here, example:

printf("\n%s %s %d", phonebook.lname[i], phonebook.fname[i], phonebook.phoneNo[i]);

In your struct you defined phoneNo as char, so how do you espect %d will work here? and the input you receive for the user as number will work?

Hmm, now I'am going out, but, look:
For copying strings, use:
strcpy()

And inputing string from a stream, use fgets()
Hmm, fix your struct, this is the main problem of your program.

No, they defined it as an array of char, which is a different thing altogether.

Right, I forgot, but still, he cant print this like %d.