can someone tell me what's wrong with this?

[gunder]

This is from a tic tac toe game I'm making, it's the function to check if there is a win or not. It's simple code so you should be able to see what I'm doing with no problems. I have it set up to check in my array if there is a win, if so it returns a 1 if no it returns a 0 .. but it never returns a 1. Here's the code.

int checkwin(void)
{ 
 if ((board[1][1] == 'X') && (board[2][0] == 'X') && (board[0][2] == 'X'))
  return ('1');
 
 else
  return('0');
}

As you can see I only have one win situation set up, just for testing. The way this works is I have a do while loop that takes the user info, puts it in the array. It's set up as a do while win = '0' loop. Then I do win = checkwin(); before the end of the loop and it doesn't do anything. Any suggestions?

[ronin]

Without seeing the entire code, your function expects an integer to be returned but you're returning the char value of '1'

How does your function know about board[][]? Since you haven't passed anything in as an argument, my guess is the poor thing doesn't know what to do. A global array?

[gunder]

The reason I have it set up using the '''s is because in my do while loop if I have do while win = 0 it just runs the loop once and quits even though I never changed win. If I do a do while win = '0' then it works fine. And yes my board array is global.

I'll attatch the full source to this post. Note to anyone who looks at it, it's not playable yet but it's readable. Look at the checkwin and twoplayer functions to see what's not working. I wrote this using dev-c++, anyone should be able to understand the code, I comment quite a bit.

[Dave_Sinkula]

>I have do while win = 0

Don't assign a value in the loop condtion (=), do a comparison (==).

do { /*...*/ }
while (win == '0');

[gunder]

Ugh, well I feel like an idiot. Thanks a lot I knew it had to be something simple like that. I can't beleive I didn't spot that, oh well thanks again.

[ronin]

Check your PM (user cp link) for a halfhearted attempt at a tic tac toe game