Thread: "subscript requires array or pointer type"?

There're quite a few problems:

Firstly, you're refering to your arrays with their dimensions attached, which is wrong. If you want to pass the array you just pass the name by itself, not with the dimension lengths. Otherwise you are accessing an offset from the array (that's out of bounds of the array too).

Firstly, you aren't realizing the fact that an int pointer just holds a memory location, not whether it points to the first element of a single dimensional array or of a multidimensional array or anything else.

This is why you can't use 2 subscipts on it when tying to access an element of the array. This is because in order to do that you have to know how many colums there are.

Think about it like this:

Memory is in a line. You make an array that has "6 row" and "3 columns."

How do you think that is put in memory? In a row. So, what happens when you try to access row 3 column 2 of that array?

Internally, what the compiler does is multiplies the row you want to access by the number of columns and adds to that the column you want to access. That number is then multiplied by the sizeof the datatype of the elements and is then used as an offset from the first location in memory.

It knows how many columns there are from the declaration of the array.

The problem is that if you use a pointer to an int to store the first element of that array, you lose all that information about the number of columns! How is it going to be able to figure out the offset if it doesn't know how many elements there are per row?

It can't.

Instead, you'd either have to pass a pointer to array with that number of columns, or a pointer to an array of that many columns and rows, or you can pass to the function info about the columns and use it to perform the above offset calculation yourself.

Before I go any further it looks as though, in your sumsquares function, you ONLY want to work with an array with 3 rows and 4 columns. Also, you apparently don't use any of the information from the other two parameters (rows and col).

So, make the parameter a pointer to an array of 3 rows and 4 columns and get rid of the other 2!

Then, when you call it, just use the array name.

But to be honest, you seem to just be messing up a lot of logic in that function. What I'm guessing you wanted to do was account for arrays of multiple dimensions and use rows and cols as the information about the dimensions to access the elements in the arrays, but if that's the case, you are doing something extremely different. Get back to me on exactly what you want somesquares to do and if it should account for arrays with varying dimensional lengths.

here's a fixed version of the code:

Code:

#include <stdio.h>
#include <math.h>
#include <stdlib.h>



/* function prototypes */
void GetData( int num[][4]);
double sumsquares( int (*num_ptr)[3][4] );



int main( void )
{
	int num[3][4] = {0};
    double sumsq = 0.0;

GetData(num);

sumsq = sumsquares( &num );
printf( "The sum of squares of each integer is: %.0f.\n", sumsq);

return 0;
}



/******************************* sumsquares() *********************************/
double sumsquares( int (*num_ptr)[3][4] )
{
	double sum = 0;
	double temp1 = 0;
	double temp2 = 0;
	double temp3 = 0;

	int rows, col;

	for ( rows = 0, col = 0; col < 4; col++)
	{
		temp1 += pow( (*num_ptr)[rows][col], 2.0 );
	}

	for ( rows = 1, col = 0; col < 4; col++)
	{
		temp2 += pow( (*num_ptr)[rows][col], 2.0 );
	}

	for ( rows = 2, col = 0; col < 4; col++)
	{
		temp3 += pow( (*num_ptr)[rows][col], 2.0 );
	}

	sum = temp1 + temp2 + temp3;

return sum;
}

/******************************* GetData() ***************************/
void GetData( int num[][4] )
{
	int i = 0;	
	char instring[15] = {0};

    printf( "Please enter the first row of four integers now: \n" );
	for ( i = 0; i < 4; i++ )
	{
		printf( "#%2d: ", i + 1 );
		num[0][i] = atoi( gets( instring ) );
	}

	
	printf( "Please enter the second row of four integers now: \n" );
	for ( i = 0; i < 4; i++ )
	{
		printf( "#%2d: ", i + 1 );
		num[1][i] = atoi( gets( instring ) );
	}

	printf( "Please enter the third row of four integers now: \n" );
	for ( i = 0; i < 4; i++ )
	{
		printf( "#%2d: ", i + 1 );
		num[2][i] = atoi( gets( instring ) );
	}
		
}

Here're the functions to be able to accept varying numbers of dimension lengths.

Code:

#include <stdio.h>
#include <math.h>
#include <stdlib.h>



/* function prototypes */
void GetData( int* num_ptr, int numrows, int numcols );
double sumsquares( int* num_ptr, int numrows, int numcols );


int main( void )
{
	int num[3][4] = {0};
	double sumsq = 0.0;

	GetData( *num, 3, 4 );

	sumsq = sumsquares( *num, 3, 4 );
	printf( "The sum of squares of each integer is: %.0f.\n", sumsq);

	return 0;
}



/******************************* sumsquares() *********************************/
double sumsquares( int* num_ptr, int numrows, int numcols )
{
	double sum = 0.0;

	for ( int row = 0; row < numrows; ++row )
		for ( int col = 0; col < numcols; ++col )
			sum +=pow( num_ptr[row * numcols + col], 2.0 );

	return sum;
}

/******************************* GetData() ***************************/
void GetData( int* num_ptr, int numrows, int numcols )
{
	int row, col;

	for ( row = 0; row < numrows; ++row )
	{
		printf( "Please input row %d of %d integers now: \n", row + 1, numcols );
		for ( col = 0; col < numcols; ++col )
		{
			printf( "#%d: ", col + 1 );
			scanf( "%d", &num_ptr[row * numcols + col] );
		}
	}	
}

Salem, the reason why we did is because he specifically stated that you should be able to pass a 2 dimensional array with each dimension being of any length. The only way he can do that is if he calculates the index himself! If you noticed my first example, i actually told him to do what you said, however, in the next post, he said the function had to allow for all different combinations of dimension lengths so I posted another response! You can't do it the way you want and I want. It's got to account for all situations!

i strongly discourage against this "flattening of the array" technique (as outlined in question 6.19 of that faq); it is not guaranteed to work.

>>... and Hammer was pretty vague.
Very vague, considering I didn't actually write anything Mistaken identity, I believe.