anything to overwrite a char array?

[Nutka]

i was just wondering how to fix my program... If user wants to enter another string (e.g. shorter one), some characters are left in the array, and the count of vowels, consonants and white spaces is not accurate. Is there a way to --- i don't know -- count the chars in the array? Without using anything from ctype.h? What can I do?

thanks...

[The Dog]

Firstly, dont use gets(), use fgets().

Seeing that fgets(), will have a '\n' at the end, you could loop up to the first '\n', and then you'll be at the end of the string.

//Change this :
for (i = 0; i <= 511; i++)

//To this :
for ( i = 0; inputstring[i] != '\n'; i++ )

[PutoAmo]

In order to count vowels use something like:

char vowels[] = {'a', 'e', 'i', 'o', 'u', 'A', 'E', 'I', 'O', 'U'}

for ( i = 0; i < 10; i++)
   if ( ch == vowels[i] )
      ch_is_a_vowel = 1;

If ch is inside the characters range but it is not a vowel, then it must be a consonant )

[moi]

char vowels[] = {'a', 'e', 'i', 'o', 'u', 'A', 'E', 'I', 'O', 'U'}

know that

char vowels[] = "aeiouAEIOU"

is easier to write and does almost exactly the same thing (the exception being it adds a '\0' to the end)

[Nutka]

Ok, I can do that. Thanks. Actually it was the first thing I thought of before I started writing this... I can change this, no problem.
Still, what should I do with the inputarray, which is filled and a next, shorter string will not overwrite the rest of the previous one?

[Nutka]

I did try to fill the new array with '\0', but it still doesn't work. The new string is located at the beginningof the array, but the older string is still right after the new one....
What is going on? What did I do wrong this time?

# include <stdio.h>



int main()
{


	char again = 'y';
	char inputstring[112] = "\0";
	char *inputptr;
	int i = 0;
	int count_vow = 0;
	int count_cons = 0;
	int count_white = 0;
	int count_punct = 0;
	int non_counted = 0;
	int tot_wh_sp_ct = 0;
	inputptr = inputstring;
	
	
	
	do
	{
		{
		printf("Enter an English text. Use at least one character and no more than 111 characters, including white spaces.\n");
		gets(inputstring);
		printf("The text you entered was:\n");
		printf("%s", inputstring);
		
		for (i = 0; i<=111; i++)
		{
			switch(inputstring[i])
			{
			case 'a': 
			case 'A': 
			case 'e': 
			case 'E': 
			case 'i': 
			case 'I': 
			case 'o': 
			case 'O': 
			case 'u': 
			case 'U': count_vow++;
			
			default: non_counted++;
			}

			switch(inputstring[i])
			{
				case 'b': 
				case 'B': 
				case 'c': 
				case 'C': 
				case 'd': 
				case 'D': 
				case 'f': 
				case 'F': 
				case 'g': 
				case 'G': 
				case 'h': 
				case 'H':
				case 'j': 
				case 'J': 
				case 'k': 
				case 'K': 
				case 'l': 
				case 'L': 
				case 'm': 
				case 'M': 
				case 'n': 
				case 'N': 
				case 'p': 
				case 'P': 
				case 'q': 
				case 'Q': 
				case 'r': 
				case 'R': 
				case 's':
				case 'S': 
				case 't': 
				case 'T': 
				case 'v': 
				case 'V': 
				case 'x': 
				case 'X':
				case 'y':
				case 'Y':
				case 'z':
				case 'Z': count_cons++;

				default: non_counted++;
			}

			switch(inputstring[i])
			{
			case ' ':
			case '\t': count_white++;
			default: non_counted++;
			}

			switch(inputstring[i])
			{
			case '.':
			case ';':
			case ',':
			case '!':
			case '?': count_punct++;
			default: non_counted++;
			}

		}
		tot_wh_sp_ct = count_white + 1;
		printf("\nand it contained %d consonants, %d vowels, %d white spaces, %d punctuation marks.",count_cons, count_vow, tot_wh_sp_ct, count_punct);
		}

	for (i=0; i<=111; i++)
	{
		inputstring[i] = '\0';
	}

	
	printf("\nWould you like to enter another text?");
	again = getchar();
	while ( getchar() != '\n' ) 
	continue;
	}
	while (again == 'y' || again =='Y');

	return 0;
}

[Hammer]

I haven't read all of your program, but in answer to your question:

what should I do with the inputarray, which is filled and a next, shorter string will not overwrite the rest of the previous one?

... What is the problem here? OK, so you're array isn't completely filled with a new string, but that doesn't matter. you know where the new string stops, because it's last character is \0. Anything after that is irrelevant. Does this help you?

Alternatively, is you're that worried, fill the array with \0 before asking the user for a new string.

[Nutka]

Oh. I finally know where the problem wasis. It's not the string array. It is the variables which stay after one run of the program. If I do not exit and re-execute the program they will be adding new values to the previous (from the previous string)....
I filled in the array with '\0', just in case.
Thanks