Thread: beginner need help

Code:

void enterstring()
{
                while(getchar()!='\n');
	printf("a string:");
	fgets(str,20,stdin);
                while(*str=='\n'||*str=='\0')
	{
		printf("\t\tneed to enter a string:");
		fgets(str,20,stdin);
	}
}

this code works fine if user enters nothing.
but if user enters a string,
2 'enter's are required to go to next line of code.
the string and 1 '\n' is also assigned to 'str'.
any help on how to reduce to 1 'enter' required and only stores the string?
been trying out gets(str), scanf("%s",str)
all have same or worse effect.
any help pls?

getchar() waits for input, so you have to press enter twice. i would suggest not using it.

(if your next question is, "how do i check to see if the buffer is clear?" don't bother... there's no standard way to do it)

you could use getch() in place of getchar(), which won't make you press enter.

>you could use getch() in place of getchar(), which won't make you press enter.
But mind it, getchar() is standard, while getch() isn't, your compiler may/maynot support it.

think my compiler doesnt support getch()
tried it but still cant work

[code]void enterstring()
{
fflush(stdin);/*does this work better than getchar()?*/
printf("\n\n\n\n\n\t\t\tenter a string:");
fgets(str,20,stdin);
while(*str=='\n'||*str=='\0')
{
printf("\t\tenter a ****ing string:");
fgets(str,20,stdin);
}
}

this code has same effect as previous.

called this function from 2 places,
one works normal
this

Code:

void menuchoice(int i)
{
	switch(i)
	{
	case 2:
		enterstring();
		checkstring();
		break;
	}
}

whereas from this place requires additional enter

Code:

void startchoice()
{
	enterstring();
	enterchar();
	checkstring();
}

for us to help you with your second question, you'd probably have to show the rest of your code.

Code:

#include<stdio.h>
#include<stdlib.h>
#include<conio.h>
char *pt;
int prt;
int check_string(char *s);
int is_in(char *s,char c);
char str[20],chr;
void startmenu();
void startchoice();
void enterstring();
void enterchar();
void checkstring();
int checkchar();
void menu();
void menuchoice(int i);
void strrmvlaschr(char *p);

int main()
{
	startmenu();

	return 0;
}

void startmenu()
{
	int i;

	printf("\n\n\n\t\tString checker\n\n\n\n");
	printf("\t1. Start\n\n");
	printf("\t2. Exit\n\n");
	printf("\tEnter a number to continue:");
	scanf("%d",&i);
	system("CLS");

	if(i==1)
	{
		startchoice();
	}
	else
		exit(0);
}

void menu()
{
	int i;

	system("cls");
	printf("\n\n\n\t\tString checker\n\n\n\n");
	printf("\t1. Enter another string and char\n\n");
	printf("\t2. Enter string ONLY\n\n");
	printf("\t3. Enter char ONLY\n\n");
	printf("\t4. Exit\n\n");
	printf("\tEnter a number to continue:");
	scanf("%d",&i);
	system("CLS");

	menuchoice(i);
}

void startchoice()
{
	enterstring();
	enterchar();
	checkstring();
}

void menuchoice(int i)
{
	switch(i)
	{
	case 1:
		startchoice();
		break;
	case 2:
		enterstring();
		checkstring();
		break;
	case 3:
		printf("\n\n");
		enterchar();
		checkstring();
		break;
	default:
		exit(0);
	}
}

int check_string(char *s)
{
	if(*s)
		return 1;
	else
		return 0;
}

int is_in(char *s,char c)
{
	while(*s)
	{
		if(*s==c)
		{
			prt=s-pt;
			return 1;
		}
		else
		{
			s++;
		}
	}
	return 0;
}

void enterstring()
{	
	fflush(stdin);
	printf("\n\n\n\n\n\t\t\tenter a string:");
	fgets(str,20,stdin);
	while(*str=='\n'||*str=='\0')
	{
		printf("\t\tenter a ****ing string:");
		fgets(str,20,stdin);
	}
	pt=str;
}

void enterchar()
{
	while(getchar()!='\n');
	printf("\n\t\t\tenter a char:");
	scanf("%c",&chr);
	while(chr=='\n')
	{
		printf("\n\t\t\tenter a ****ing char:");
		scanf("%c",&chr);
	}
}

void checkstring()
{
	strrmvlaschr(str);
	if(is_in(str,chr))
	{
		printf("\n\t\t'%c' is located in \"%s\" at postion %d.\n\n",chr,str,prt+1);
		for(long int t=0;t<90000000;t++);
		menu();
	}
	else
	{
		printf("\n\t\t**** u '%c' no found.\n\n",chr);
		for(long int t=0;t<90000000;t++);
		menu();
	}
}

void strrmvlaschr(char *p)
{
	p=str;
	while(*p)
	{
		if(*p=='\n')
			*p='\0';
		p++;
	}
}
int checkchar()
{
	if(chr=='\n')
		return 0;
	else return 1;
}

thanks for time and help

to pause the code till enter key is pressed, use this function:

Code:

void waitforenterkeypress()
{
	char c;

	do
	{
	} while((c = getch()) != 13); 	
}

getch is in conio.h

Ok, it looks like it requires pressing enter an extra time because of how you go into startchoice(). I'm not familiar with scanf(). If it requires you to press enter, I would say that's probably the reason.

Code:

void startmenu()
{
	int i;

	printf("\n\n\n\t\tString checker\n\n\n\n");
	printf("\t1. Start\n\n");
	printf("\t2. Exit\n\n");
	printf("\tEnter a number to continue:");
	scanf("%d",&i);
	system("CLS");

	if(i==1)
	{
		startchoice();
	}
	else
		exit(0);

thx for time i try to play around with codes