Thread: logo programming

yoo .well i am trying to creat a turtle graphic program ..this is what i have done so far it has some logical errors ..the programm crashes and yeah a hint tip would be good.. should i use function will it help me alot in this particular program ???

Code:

#include <stdio.h>
#include <stdlib.h>
#define ROW 50
#define COL 50

int main(int argc, char *argv[])
{
	int a[ROW][COL] = {0};
	int i, j, choose, pen, loop, cnt;

	printf ( "Enter a number: ");
	scanf ("%d", choose );
		
	while (choose != 9)
	{
		switch (choose)
		{
		case 1:
			pen = 1;
			break;

		case 2:
			pen =2;
			break;

		case 3:
			a[i--][j];
			break;

		case 4:
			a[i++][j];
			break;

		case 5:
			printf ("Enter the number of spaces to move: ");
			scanf ("%d", &loop );
			for (cnt=0; cnt <= loop-1; cnt++ )
			{
				a[i++][j++] = 1;
			}
			break;

		case 6:
			for (i=0;i <= ROW-1 ;i++ )
			{
				for (j=0; j <= COL-1;j )
				{
					if (a[i][j]==1)
						printf ("*");
					else
						printf(" ");

					
				}			    
				
				
			}
			break;

		case 9:
			break;

		default:
			printf ("Sorry wrong number");
			break;
				
		}

		printf ("Enter a number: ");
		scanf ("%d", choose );
	}
	
	
	return 0;
}

Thanks alot

>scanf ("%d", choose );
You forget the & before choose:
>scanf ("%d", &choose );

>a[i--][j];
>a[i++][j];
This does nothing. Review this line and make it do something!
Also, neither i or j are initialised.

>should i use function will it help me alot in this particular program
Functions always help you, they are invaluable. Do you _need_ them in your program though.... that's up to you to decide

Code:

#include <stdio.h>
#include <stdlib.h>
#define ROW 50
#define COL 50

int main(int argc, char *argv[])
{
	int a[ROW][COL] = {0};
	int i=0;, j=0;, choose, pen, loop, cnt;

	printf ( "Enter a number: ");
	scanf ("%d", &choose );

	if (i > 50)
	{
		printf( "Sorry row exceeded\n"), --i;
	}
	if (j > 50)
	{
		printf ("Sorry column exceeded\n"), --j;
	}		
	
		
	while (choose != 9)
	{
		switch (choose)
		{
		case 1:
			pen = 1;
			break;

		case 2:
			pen =2;
			break;

		case 3:
            a[i--][j];
			break;

		case 4:
            a[i++][j];
			break;

		case 5:
			printf ("Enter the number of spaces to move: ");
			scanf ("%d", &loop );
			for (cnt=0; cnt <= loop-1; cnt++ )
			{
				if (pen =1)
				{
					a[i++][j++] = 0;
				}
				else if (pen = 2)
				{
					a[i++][j++] = 1;
				}
			}
			break;

		case 6:
			for (i=0;i <= ROW-1 ;i++ )
			{
				for (j=0; j <= COL-1;j++ )
				{
					if (a[i][j]==1)
						printf ("*");
					else
						printf(" ");

					
				}			    
				
				
			}
			break;

		case 9:
			break;

		default:
			printf ("Sorry wrong number");
			break;
				
		}

		printf ("Enter a number: ");
		scanf ("%d", &choose );
	}
	
	
	return 0;
}

Any tips to help me out hints to make it better ..and yeah how will change the direction of the turtle ...

Thanks alot
Its 5 AM in the morning

>Its 5 AM in the morning
... and you need some sleep, pal

>Any tips to help me out hints to make it better
Yeah, fix the errors that stop it from compiling first

To stop (my) compiler moaning, declare your array like this:
>int a[ROW][COL] = {{0,0}};

>int i=0;, j=0;, choose, pen, loop, cnt;
This has an obvious typo in it (2 actually).

>a[i--][j];
This STILL has no effect. This was in my last post.

>if (pen =1)
>else if (pen = 2)
Incorrect assignment, I believe.

>>..and yeah how will change the direction of the turtle ...
Fix the above first!

Code:

#include <stdio.h>
#include <stdlib.h>
#define ROW 50
#define COL 50

int main(int argc, char *argv[])
{
	int a[ROW][COL] = {{0,0}};
	int i=0, j=0, choose, pen, loop, cnt;

	printf ( "Enter a number: ");
	scanf ("%d", &choose );

	if (i > 50)
	{
		printf( "Sorry row exceeded\n"), --i;
	}
	if (j > 50)
	{
		printf ("Sorry column exceeded\n"), --j;
	}		
	
		
	while (choose != 9)
	{
		switch (choose)
		{
		case 1:
			pen = 1;
			break;

		case 2:
			pen =2;
			break;

		case 3:
            a[i--][j];
			break;

		case 4:
            a[i++][j];
			break;

		case 5:
			printf ("Enter the number of spaces to move: ");
			scanf ("%d", &loop );
			for (cnt=0; cnt <= loop-1; cnt++ )
			{
				if (pen ==1)
				{
					a[i++][j++] = 0;
				}
				else if (pen == 2)
				{
					a[i++][j++] = 1;
				}
			}
			break;

		case 6:
			for (i=0;i <= ROW-1 ;i++ )
			{
				for (j=0; j <= COL-1;j++ )
				{
					if (a[i][j]==1)
						printf ("*");
					else
						printf(" ");

					
				}			    
				
				
			}
			break;

		case 9:
			break;

		default:
			printf ("Sorry wrong number");
			break;
				
		}

		printf ("Enter a number: ");
		scanf ("%d", &choose );
	}
	
	
	return 0;
}

Well a[i--][j]; since i dont know how to change the direction i cant do anything with it next time i will make sure i take care of these small errors .. it sems asif we both are in the same time zone ... just alil tips on the direction??

>just alil tips
I would suggest that you redesign the program so that when you start writing it you only have to deal with syntax errors. A well designed program will have no logic errors when it gets to the coding stage. Here is a simple example of what I mean, I designed things first and then wrote the code. The result is more intuitive and works better than if I had just started coding right away. I also finished more quickly as well, I can't stress good design enough:

Code:

#include <stdio.h>
#include <stdlib.h>

#define ROW_LEN 10
#define COL_LEN 10

#define FLUSH_INPUT while ( getchar() != (int)'\n' )

struct TURTLE
{
  int row_pos,
      col_pos;
};

enum DIRECTION { LEFT, RIGHT, UP, DOWN, DONE, INVAL };
enum MOVE_VAL  { VALID, INVALID, COMPLETE };

/*
** typedef the enums for ease of use.
*/
typedef enum DIRECTION dir_t;
typedef enum MOVE_VAL  move_t;

/*
** Functions are good. :)
*/
static void prompt ( void );
static dir_t getDirection ( void );
static move_t moveTurtle ( dir_t direction );
static void clearMap ( void );
static void redrawMap ( void );

/*
** Globals used for simplicity in this program.
*/
static char map[ROW_LEN][COL_LEN];
static struct TURTLE turtle;

int main ( void )
{
  move_t done = VALID;
  while ( done != COMPLETE ) {
    prompt();
    done = moveTurtle( getDirection() );
  }
  return EXIT_SUCCESS;
}

static void prompt ( void )
{
  (void)puts ( "1) Move Up" );
  (void)puts ( "2) Move Down" );
  (void)puts ( "3) Move Left" );
  (void)puts ( "4) Move Right" );
  (void)puts ( "5) Exit Program" );
  printf ( "Choose an option: " );
}

static dir_t getDirection ( void )
{
  int selection;
  dir_t where_to = INVAL;
  while ( where_to == INVAL ) {
    selection = getchar();
    FLUSH_INPUT;
    switch ( selection ) {
    case '1': where_to = UP;    break;
    case '2': where_to = DOWN;  break;
    case '3': where_to = LEFT;  break;
    case '4': where_to = RIGHT; break;
    case '5': where_to = DONE;  break;
    default:
      fprintf ( stderr, "Invalid input, please try again: " );
      break;
    }
  }
  return where_to;
}

static move_t moveTurtle ( dir_t direction )
{
  move_t check = VALID;
  switch ( direction ) {
  case UP:
    if ( turtle.row_pos > 0 )
      turtle.row_pos--;
    else
      check = INVALID;
    break;
  case DOWN:
    if ( turtle.row_pos < ROW_LEN - 1 )
      turtle.row_pos++;
    else
      check = INVALID;
    break;
  case LEFT:
    if ( turtle.col_pos > 0 )
      turtle.col_pos--;
    else
      check = INVALID;
    break;
  case RIGHT:
    if ( turtle.col_pos < COL_LEN - 1 )
      turtle.col_pos++;
    else
      check = INVALID;
    break;
  case DONE:
    /*
    ** All done, we can return the exit value. No cleanup is required.
    */
    return COMPLETE;
  case INVAL:
    /*
    ** This should never happen, handle it however you like.
    */
    break;
  }
  if ( check == INVALID )
    fprintf ( stderr, "The chosen direction is out of bounds\n" );
  else {
    clearMap();
    redrawMap();
  }
  return check;
}

static void clearMap ( void )
{
  int i, j;
  for ( i = 0; i < ROW_LEN; i++ ) {
    for ( j = 0; j < COL_LEN; j++ )
      map[i][j] = ' ';
  }
}

static void redrawMap ( void )
{
  int i, j;
  /*
  ** Mark the current location and print.
  */
  map[turtle.row_pos][turtle.col_pos] = '*';
  for ( i = 0; i < ROW_LEN; i++ ) {
    for ( j = 0; j < COL_LEN; j++ )
      (void)putchar ( map[i][j] );
    (void)putchar ( '\n' );
  }
}

-Prelude

Thanks alot...but see it really dint help me out coz i have not done structures and i dont know hwat enum is and yeah fprintf???? Plzzz some thing that i can relate to will help .....Is hammer out there .....
Thanks alot

I think you need to clarify what you're trying to do here. If it's a simple "move a marker around a grid" type program you're after, Prelude's code does just that. You may not understand some of the syntax yet, but study it hard and try to.

In the meantime, here's some pseudo code that attempts to show you how to code this type of program. It doesn't show any error checking or such, it's just a basic frame work.

Code:

10 ROWS = 20
20 COLS = 20
30 CurrentRow = 0
40 CurrentCol = 0

50 Direction = GetDirectionFromUser
60 MoveTurtle(Direction)
70 DisplayGrid
80 goto 50   /* Don't use the goto keyword in your C code though! */


Function MoveTurtle(Direction)
{
    if Direction = UP
        if CurrentRow > 0
            CurrentRow = CurrentRow - 1
    if Direction = DOWN
        if CurrentRow < ROWS
            CurrentRow = CurrentRow + 1
    if Direction = LEFT
        if CurrentCol > 0
            CurrentCol = CurrentCol - 1
    if Direction = RIGHT
        if Current < COLS
            CurrentCol = CurrentCol + 1
}

Function DisplayGrid
{
    /* This will print a grid of 0's, with one cell being a 1 */
    Grid[ROWS][COLS] = {{0,0}}
    Grid[CurrentRow][CurrentCol] = 1
    for ( i = 0; i < ROWS; i++ ) {
        for ( j = 0; j < COLS; j++ )
            printf("%d", Grid[i][j]);
}

>>>printf ("Enter the number of spaces to move: ");
If you want to do this, you'll need to expand the MoveTurtle function to accept a number representing the distance. This will then need to be used in if statements to ensure you don't go out of bounds.

Originally posted by Crimpy

I think the point of Prelude's post was that you're having problems because your design sucks. From what I've seen, he probably used the code he posted as an example of a good design, not what you need to do with your code.

First thing first...Crimply wimpy what ever ya name is read this STFU.. Read a post and try to understand it before awnsering...

Code:

#include <stdio.h>
#include <stdlib.h>
#define ROW 50
#define COL 50

static void cleararray(void);
static void Directions( int [] [COL], int, int, int );
static void printfloor( int [] [COL], int, int, int, int);

int main(int argc, char *argv[])
{
	int floor[ROW][COL];
	int i, j, rowpos, colpos, choose, pen_up_down;

	for (i=0;i <=ROW-1;i++ ) /*Initialize arrays to zero*/
	{
		for (j=0;j<=COL-1;j++ )
		floor[i][j]=0;
	}

	printf ("Turtle Graphics program(Logo programming)\n"
			"Enter tne following command in integer\n"
			"[1] Pen Up\n"
			"[2] Pen Down\n"
			"[3] Right\n"
			"[4] Left\n"
			"[5] (Enter # of spaces to move)\n"
			"[6] Print the array\n"
			"[9] End the programm\n");
	scanf ("%d", &choose);

	while (choose != 9)
	{
	
		switch (choose)
		{
		case 1:
			pen_up_down = 0;
		break;

		case 2:
			pen_up_down = 1;
		break;

		case 3:
			Directions(floor[][COL], choose, i, j);
		break;

		case 4:
			Directions(floor[][COL], choose,i, j);
		break;

		case 5:
			printarray(floor[][COL],choose, pen_up_down, i, j);
		break;

		case 6:
			for (i=0;i <= ROW-1;i++ )
			{
				for (j=0;j<= COL-1; j++ )
				floor[i][j]=0;			
			}

		case 9:
			break;
		default:
			printf ("Invalid command.Please Enter again");
		break;
		}
			printf ("Enter command: ");
			scanf("%d", &choose );
	}
	


	system("pause");	
	return 0;
}

void Directions ( int a[][], ch, cnt, cnt1 )

{
	int count, count1;
    cnt =0;
	cnt1 = 0;
	switch (ch)
	{
		case 3:
			for (count = cnt; count <= cnt; count++, cnt++)
			{
				for (count1 = cnt1; count <= cnt1; count++)
				{
					a[count][count1];
				}
			}

		case 4:
			for (count= cnt;count <=cnt;  count++ )
			{
				for (count1 = cnt1;count1 <= cnt1; count1++, cnt1++ )
				{
					a[count][count1];
				}
			}
			
	
	}

void printarray ( int array[][], cho, pen, x, y );
	{

Well hammer no that not what i wanna do ....
here is the link http://cboard.cprogramming.com/showt...urtle+graphics
Well prelude stuff was not what i needed so it dint help a bit ..but still his code dint go in a wast ... i learned some new stuff from it ..The code above is just an example if i should continue
if not i better sit my ass down and think properly well i mostly program at night times so its really a stress....

If my code suck let me know so i can go through it properly ...

>I think the point of Prelude's post was that you're having
>problems because your design sucks. From what I've seen, he
>probably used the code he posted as an example of a good
>design, not what you need to do with your code.

>First thing first...Crimply wimpy what ever ya name is read this
>STFU.. Read a post and try to understand it before awnsering...
I think you should both just relax. This is a help forum, not a flame board.

>If my code suck let me know so i can go through it properly ...
You are on the right track, have you tried using pseudocode to test your design before typing it in as C? For what you are trying to do (exactly, since you didn't like my last help), I came up with this for bare bones PDL:

Code:

BEGIN
  SET pen to down
  SET choice to anything but exit
  WHILE choice is not exit
    PRINT menu
    INPUT choice
    SELECT choice
      CASE 1
        MOVE up
      CASE 2
        MOVE down
      CASE 3
        MOVE left
      CASE 4
        MOVE right
      CASE 5
        SET pen to up
      CASE 6
        SET pen to down
    END SELECT
    IF pen is down
      MARK the last movement
    PRINT map
  LOOP
END

From that it was very easy to write the corresponding C code (in a simple manner):

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#define ROW_LEN 10
#define COL_LEN 10
#define PEN_DOWN 1
#define PEN_UP   2
#define QUIT    '9'

int main ( void )
{
  int i, j;
  int choice = 0;
  int pen = PEN_DOWN;
  int row_pos = 0, col_pos = 0;
  char map[ROW_LEN][COL_LEN];

  for ( i = 0; i < ROW_LEN; i++ )
    for ( j = 0; j < COL_LEN; j++ )
      map[i][j] = ' ';
  while ( choice != QUIT ) {
    printf ( "1) Move up\n" );
    printf ( "2) Move down\n" );
    printf ( "3) Move left\n" );
    printf ( "4) Move right\n" );
    printf ( "5) Pen up\n" );
    printf ( "6) Pen down\n" );
    printf ( "9) Exit program\n" );
    printf ( "Make a selection: " );
    choice = fgetc ( stdin );
    while ( fgetc ( stdin ) != '\n' );

    switch ( choice ) {
    case '1':
      if ( row_pos > 0 )
        row_pos--;
      break;
    case '2':
      if ( row_pos < ROW_LEN - 1 )
        row_pos++;
      break;
    case '3':
      if ( col_pos > 0 )
        col_pos--;
      break;
    case '4':
      if ( col_pos < COL_LEN - 1 )
        col_pos++;
      break;
    case '5':
      pen = PEN_UP;
      break;
    case '6':
      pen = PEN_DOWN;
      break;
    case '9':
      exit ( EXIT_SUCCESS );
    default:
      printf ( "ERROR: Invalid input\n" );
    }
    if ( pen == PEN_DOWN )
      map[row_pos][col_pos] = '*';
    /*
    ** Draw the map.
    */
    for ( i = 0; i < ROW_LEN; i++ ) {
      for ( j = 0; j < COL_LEN; j++ )
        fputc ( map[i][j], stdout );
      fputc ( '\n', stdout );
    }
  }
  return 0;
}

The user interface is very unfriendly according to your design and the actions are not exactly what you asked for, but an exact copy of the program you posted was not my intention. If you follow the same method, you can write your program in a similar fashion. Just so there is no confusion and flaming this time, I'm not giving you code, I'm giving you an idea of how to go about creating a program.

-Prelude

Use a 50-by-50 array floor which is initialized to zeros.Read commands from an array that contains them.Keep track of the current position of the turlte at all times and whether the pen is currently up or down.Assume that the turtle always starts at position 0,0 of the floor with its pen up.The set of turtle commands your programm must process are as follows:

[1]Pen up
[2]Pen down
[3]Turn right
[4]Turn left
[5,10]Move forward 10 spaces(or a number other than 10)
[6]Print the 20-by-20 array
[9]End of data(sentinel)

Suppose that turtle is somewhere near the center of the floor.The following "program" would draw and print a 12-by-12 square.
2
5,12
3
5,12
3
5,12
3
5,12
1
6
9

As the turntle moves with the pen down, set the appropraite elements of array floor to 1s.When the 6 command (print) is givin, wherever there is a 1 in the aray, display an asterisk.Wherever ther is a 0 display a blank.

Okey this is the question i got it from C how to programm ....hummm.i have tried my best but dint come up with any thing ..well after reading where its sayd i should use arrays to store my commands ...i just said to self ..i better start the next chapter ....

Okay i wanted to know in the question it sayd i should store the command in an array how would i do that.After storing will i use logical operators to tell if command was 1 then do this etc etc..?