Thread: I think i jacked this up completely. Help?

I am trying to get this to shift ABCDE...BCDEA...CDEAB. Whats up with the program?

Can anyone tell me where my mistakes are?

Code:

#include<stdio.h>

void shift(char *p1, char *p2, char *p3, char *p4, char *p5);
void shift(&c1,&c2,&c3,&c4,&c5);

int main()
{
void shift(char *p1, char *p2, char *p3, char *p4, char *p5);
void shift(&c1,&c2,&c3,&c4,&c5);


shift(char *p1, char *p2, char *p3, char *p4, char *p5)
{
    #define END_INDEX 4
    int iCurrentShift = 0, iCurrentCharIndex = 0 ;
	char c1='A', c2='B', c3 ='C', c4 ='D', c5 ='E' ; 
    char cFirstLetter ; 

    for( iCurrentShift = 1 ; iCurrentShift <= iShiftCnt ; iCurrentShift++) 

    {
        cFirstLetter = letter[ 0 ];  /* save the first as we're moving something in there */
        for( iCurrentCharIndex = BEGIN_INDEX ;  /*if BEGIN_INDEX = 0 & its equal to currentcharindex then goto next statement*/
                iCurrentCharIndex <= END_INDEX - 1;
                    iCurrentCharIndex++)
        {
            letter[ iCurrentCharIndex ] = letter[ iCurrentCharIndex + 1];
        } /* end for icurrentcharindex */
 
        letter[END_INDEX ] = cFirstLetter ;
   return 0;
}

Code:

char *Shift( char[] );

int main()
{

 char string[] = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";

 int i = 53;

 while(--i)
 {
   clrscr();
   printf("%s", Shift( string ));
   Sleep(100);
   //getch();  //...use this if not including <windows.h>...
  }

getch();   

return 0;
}




char* Shift( char str[] )
{
 int i;
 int length = strlen(str);
 char temp = str[0];        //...copy first char and save...
 
 for(i = 0;  i < length - 1;  i++)  //...carefull with bounds...
  {
    str[i] = str[i+1];           
  }
 
  str[i++] = temp;
  
  str[i] = 0;                      //...null terminate, to be sure...

return str;                     //...return for printing...
}

Originally posted by sguruprasanna
You can have a look at this code:

void main()
{
char s[] = {"ABCDE"};

for(int i=0; i<5; i++)
{
for(int j=i; j<i+5; j++)
{
cout<<s[j%5];
}
cout<<endl;
}
}

rgds,
S.Guruprasanna

Hi, S.Guruprasanna. I see this is your first post on the board... welcome.

Allow me to point out a couple of problems...
>void main()
is wrong, main returns an int. It should be
>int main(void)

and the cout function is part of a C++ class. This is board is here to talk about C specifically, so please don't provide answers with C++ code, or else you'll confuse the newbies