Thread: Split numbers and alpha

Code:

while( string[x] )
{
    if( isdigit( string[x] ) )
    {
        digit[y++] = string[x];
    }
    else
    if( isalpha( string[x] ) )
    {
        alpha[z++] = string[x];
    }
    x++;
}

Assuming this is what you want, here's an easy implementation.

Quzah.

How exactly is it sluggish? Even if you were using strchr and then copying chunks out at a time, you still have to go through a single character at a time. Sluggish? I think not. This is probably *THE FASTEST* implementation you're going to get. There is nothing sluggish about it.

You have no overhead from unneeded function calls. You have at most 4 checks per loop and one assignment. I'd like to see it implemented faster. The only way to speed this up would be to replace the 'isdigit' / 'isalpha' checks with simple mathmatic comparisons.

Quzah.

the only way i see quzah to speed this up other than mentioned is some(possiblly complicated) pointer arithmetic, but the speed gain would for the most part be negligible.

Originally posted by Unregistered
sorry dude...but perhaps sluggish was not the right word.
what i meant is that the program keeps on putting the number 2 after I print alpha. ex: fhdgshjk2

Well then you're doing it wrong.

char alpha[BUFZIS] = {0};
char digit[BUFSIZ] = {0};
char string[BUFSIZ] = {0};

... read ...
... loop ...

printf("Alpha: %s\n", alpha );
printf("Digit: %s\n", digit );

If you're calling all of this in a loop, then you need to zero value your strings when you're done with them. Use memset or something similar.

Quzah.