A quick buffer issue

[Merld_One]

Oh boy, I got nearly no sleep last night, woke up WAY too early, and hopped straight away into this coding project, so what I ask may be very simple, but this coffee has not kickstared by brain yet.. Those who know me know I've coded for quite a while now, so forgive my brain-absence today!
ok, what is wrong with this loop?! Code snippits follow:

int i; iter;
i=atoi(argv<2>);
char *sendbuf;
...
for (iter=1; iter<(i=1); iter++)
sendbuf = "A";

?? Looks fine to me, but when I compile, I get the warning (yes, only a warning) : Warning: Assignement makes integer from a pointer without a cast.
The warning refers to the sendbuf line.. What the hell?? I don't see the problem here.. Then, whenever I run it, even with a tiny amount of data in the buffer (ie, not even half of the buffer size) I get a segmentation fault.. Grrr, I'm not overflowing any buffers that I can see, so why the seg fault?? Any idea's?

On FreeBSD, btw..

Thanks!

The Merld One

[Merld_One]

#include <stdio.h>
#include <netdb.h>
#include <sys/socket.h>
#include <unistd.h>
#include <netinet/in.h>

#ifndef _BSD_SOURCE
#define _BSD_SOURCE 1
#endif

void die(char *error) {
perror(error);
exit(1);
}

main(int argc, char **argv) {

int sock, i;
char *ip;
unsigned short int port;
struct sockaddr_in target;
char *sendbuf;
int iter;
if (argc != 4) die("Usage is ./filename ip port size");
if ((sock=socket(PF_INET, SOCK_RAW, 2)) < 0) die("No Socket");
ip=argv[1];
port=atoi(argv[2]);
i=atoi(argv[3]);

memset(&target, 0, sizeof(target));
target.sin_family=AF_INET;
target.sin_port=htons(port);
target.sin_addr.s_addr=inet_addr(ip);

for (iter=1; iter <= (i-1); iter++)
strcpy(sendbuf[iter],"A");
strcpy(sendbuf[i],NULL);

if (connect(sock, (struct sockaddr *) &target, sizeof(target)) < 0) die("Connect()");
if (send(sock, sendbuf, sizeof(sendbuf), 0) < 0) die("Could not send");


}

[Unregistered]

From what I can see, you have never allocated any memory space to *sendbuf.

Also, sendbuf="A" doesn't work in C. What I think you meant was sendbuf[i]='A'.

[Merld_One]

lol!!!

Thanks man.. Like I said, I aint quite woke up yet.. :-)

-Merld

[Shiro]

>ip=argv[1];

Realise that you haven't allocated memory for ip, if ip is meant to be a buffer of chars.

>port=atoi(argv[2]);

Function atoi() returns an int, port is declared as a short int, this may cause problems.