Thread: Segmentation fault

Hello, I am currently reading book and in the following code it is supposed to output the text: "Hi, Bub"

im sure ive made a mistake but when I try to run the program*(Edit) I get segmenation fault error and no other error.

Code:

#include <stdio.h>

void printAGreeting( char* greeting ) {
printf( "%s" , greeting );
}

void printAComma( void ) {
printf( ", ");
}

void printAnAddressee( char* aName ) {
printf( "%s" );
}

void printANewLine() {
printf( "\n" );
}

void printGreeting( char* aGreeting , char* aName ) {
printAGreeting( aGreeting );
printAComma();
printAnAddressee( aName );
printANewLine();
}

int main() {
printGreeting( "Hi" , "Bub" );
return 0;
}

I have tried modifying the program twice I think the book is wrong.

if someone could please point out to me what ive done wrong. As im trying to read this book and i had to go past this page without understanding what ive done wrong.

hello here is another page in the book and i am getting the same error after trying to run the code

Code:

#include <stdio.h>

// function prototypes

void printGreeting(  char* aGreeting , char* aName );
void printAGreeting( char* greeting );
void printAnAddressee( char* aName );
void printAComma( void );
void printANewline();

int main() {

printGreeting( "Hi" , "Bub" );
return 0;
}

void printGreeting( char* aGreeting , char* aName ) {
printAGreeting( aGreeting );
printAComma();
printAnAddressee ( aName );
printANewline();
}

void printAGreeting( char* greeting ) {
printf("s" , greeting);
}
void printAnAddressee( char* aName ) {
printf ( "%s" );
}

void printAComma( void ) {
printf( ", " );
}

void printANewline() {
printf( "\n" );
}

Is this book useless. The names are all too close together and it doesn't have any comments in the example.code

Originally Posted by kowhai

Hello, I am currently reading book and in the following code it is supposed to output the text: "Hi, Bub"

im sure ive made a mistake but when I try to run the program*(Edit) I get segmenation fault error and no other error.

Out of curiosity, what book are you reading?

There are others that are better for learning C.

Learn C Programming by Jeff Szuhay

What would you recommend

Originally Posted by kowhai

What would you recommend

I have not read this book, only the table of contents. It seems to be somewhat thorough, but I cannot comment on the actual text, and code examples of the book.

I usually recommend the following, as I have done in many posts on this site:

-----------------

If you are attempting to learn from painfully inadequate online tutorials, YouTube videos, or some book claiming to teach you in a short time, then THROW THEM AWAY!

Short of taking a course in C Programming from a qualified instructor, you need to study a good book on the C Programming Language, cover to cover, and do all the exercises at the end of each chapter! Choose one of the three listed below:

C Programming, A Modern Approach, 2nd Edition
Author: K. N. King

C Primer Plus, 6th Edition
Stephen Prata

C How to Program, 8/e
Deitel & Deitel

Studying one of these books, and writing code, you will have a much better understanding of the C Programming language.

I'll have a look at buying one of those books. I only could afford this book so hopefully there are no more.mistakes in the example.code