Thread: swapping array value

I am trying to sort array in increasing order

my approach for sequence 5 4 3 2 1 is like following

5 > 4 True 4 5 3 2 1

5 > 3 True 4 3 5 2 1

5 > 2 True 4 3 2 5 1

5 > 2 True 4 3 2 1 5


4 > 3 True 3 4 2 1 5

4 > 2 True 3 2 4 1 5

4 > 1 True 3 2 1 4 5

and so on ...

Code:

  #include<stdio.h>

int main()
{
    int array[5] = {5, 4, 3, 2, 1 };
	int temp[5];
	
	for ( int i = 0; i < 5; i++)
	{
		for ( int j = 0; j < 5; j++)
		{
			if (array[i] > array[j+1])
			{
				temp[i] =  array[i];
			}			
			
			
		}
	}
	
	for ( int i = 0; i < 5; i++)
	{
		printf("%d", temp[i]);
	}
	
	return 0;
}

I am struggling in swapping array value

I know swapping

x = 1
y = 100
temp =x
x = y = 100
y = temp = 1

Originally Posted by Salem

> I know swapping
So why can't you replace those things with array[i] and array[j] ?

Also, your j loop has the same mistake as your previous thread.
You don't start at 0, you start at i

I am struggling with swapping inside inner loop

Code:

   #include<stdio.h>

int main()
{
    int array[5] = {5, 4, 3, 2, 1 };
	int temp[5];
	
	for ( int i = 0; i < 5; i++)
	{
		for ( int j = i+1; j < 5; j++)
		{
			if (array[i] > array[j])
			{
				temp[i] =  array[j];
				array[i] = temp[i];  
			}			
			
			
		}
	}
	
	for ( int i = 0; i < 5; i++)
	{
		printf("%d", temp[i]);
	}
	
	return 0;
}

11116422280

There is no temp[i]. You only ever need one temporary variable, to hold the value that you are swapping right now. So just store and load to temp.

And why would you print temp[i]? You're not sorting that array, you're sorting the array array. Print that!

Originally Posted by aghast

There is no temp[i]. You only ever need one temporary variable, to hold the value that you are swapping right now. So just store and load to temp.

And why would you print temp[i]? You're not sorting that array, you're sorting the array array. Print that!

I tried but it doesn't give correct output

Code:

  #include<stdio.h>

int main()
{
    int array[5] = {5, 4, 3, 2, 1 };
	
	int temp;
	
	for ( int i = 0; i < 5; i++)
	{
		for ( int j = i+1; j < 5; j++)
		{
			if (array[i] > array[j])
			{
				temp =  array[i];
				array[j] = array[i];  
				array[j] = temp;
			}			
			
			
		}
	}
	
	for ( int i = 0; i < 5; i++)
	{
		printf("%d", array[i]);
	}
	
	return 0;
}

55555

Originally Posted by Kittu20

I tried but it doesn't give correct output

Because it is wrong still...
Pay attention on what you did on swapping...

Originally Posted by flp1969

Because it is wrong still...
Pay attention on what you did on swapping...

Thanks

Code:

  #include<stdio.h>

int main()
{
    int array[5] = {5, 4, 3, 2, 1 };
	
	int temp;
	
	for ( int i = 0; i < 5; i++)
	{
		for ( int j = i+1; j < 5; j++)
		{
			if (array[i] > array[j])
			{
				temp =  array[i];
				array[i] = array[j];
				array[j] = temp;
				
				
			}			
			
			
		}
	}
	
		for ( int i = 0; i < 5; i++)
	{
		printf("%d", array[i]);
	}
	return 0;
}