Thread: Loop and Side-Effect

2. Handle error block in while loop,
- Set variable "err" to TRUE;
- Exit while loop;

Handle error block outside while loop;
- Clean up

3. Array[i] is null before while loop,
therefore it will never be executed.

Note that array[i] changes in while loop.



Also don't deduce anything from a dummy code..
The boolean method is good, much better than an infinite loop.

Originally Posted by kodax

2. Handle error block in while loop,
- Set variable "err" to TRUE;
- Exit while loop;

Handle error block outside while loop;
- Clean up

3. Array[i] is null before while loop,
therefore it will never be executed.

Note that array[i] changes in while loop.



Also don't deduce anything from a dummy code..
The boolean method is good, much better than an infinite loop.

Judging by how small the function is I question the logic in handling errors outside the loop, just handle it inside and return:

Code:

int  catch_error(char *pos);

int foo(char array[]) {
	int i = 0, used = 0;
	if ( !array )
		return -1;
	while ( array[i] )
	{
		used = 1;
		if (catch_error(array + i))
		{
			// Whatever error handling you need here
			return -1;
		}
		// more code
		i += used;
	}
	return i;
}

Originally Posted by kodax

One can only wonder the powers that you possess,
to judge something that you can't see, and to question it.

Powers that the common man can only dream of, no doubt.

Originally Posted by kodax

Can this be considered as a side-effect, bad practice ?

Code:

char empty[1] = {0};

while (array[i]) {

    // more code

    if (abc()) {
        array = empty;
        i = -1;

    }
    i = 1 + i;
}

Need I say more?

Originally Posted by hamster_nz

Amazing powers, like posting 8 lines of code that can't be run because it is incomplete, asking for opinions:

Code:

char empty[1] = {0};
while (array[i]) {
  if (abc()) {
    array = empty;
    i = -1;
  }
  i = 1 + i;
}

then thinking it is ok to get snarky with people for making assumptions:




That is almost literally what you have asked everybody here to do.

Also you:





Well, perhaps in future post the actual code that shows the actual problem, not some incomplete snippet.

Maybe next time post something complete, that will actually compile and demonstrate the issue????

I really should read other posts more often, ended up doubling up on your reply

Another kodax bait-and-switch strawman nonsense garbage thread bites the dust.