Thread: Conditional Statement Issues

Consistent code formatting would definitely have helped to find this issue earlier.

Code:

#include <stdio.h>

int main()
{
  float salt, pepper, garlic, thyme;

  printf("Lets cook!\n");
  printf("====================\n");
  printf("\n");
  printf("Amount of salt added? ");
  scanf("%f", &salt);
  printf("Amount of pepper added? ");
  scanf("%f", &pepper);
  printf("Amount of garlic added? ");
  scanf("%f", &garlic);
  printf("Amount of thyme added? ");
  scanf("%f", &thyme);

  if (pepper < 1.5) {
    printf("Needs more pepper\n");
  } 
  else if (pepper > 3.5) {
    printf("Too much pepper!\n");
  }

  if (salt < 5.5) {
    printf("Needs more salt\n");
  } 
  else if (salt > 13) {
    printf("Too salty!\n");
  }

  if (garlic < 2) {
    printf("Needs more garlic\n");
  } 
  else if (garlic > 4) {
    printf("Too much garlic!\n");
  }

  if (thyme < 0.5) {
    printf("Needs more thyme\n");
  } 
  else if (thyme > 1.25) {
    printf("Too much thyme!\n");
  }
  else {
    printf("Delicious!\n");
  }

  return 0;
}

Yes, the "else" only attaches to the last of the "if"/"else if" constructs.

This is one possible fix but it will only print out one of the out-of-bounds ingredients.

Code:

if (a < 1)
    printf("...");
else if (a > 9)
    printf("...");
else if (b < 1)
    printf("...");
else if (b > 9)
    printf("...");
else
    printf("yum!\n");

To print out all of the offending ingredients you could use a flag.

Code:

int okay = 1;
 
if (a < 1) {
    printf("...");
    okay = 0;
}
else if (a > 9) {
    printf("...");
    okay = 0;
}
 
if (b < 1) {
    printf("...");
    okay = 0;
}
else if (b > 9) {
    printf("...");
    okay = 0;
}
 
if (okay)
    printf("yum!\n");

Or if you want to get fancy:

Code:

#include <stdio.h>
#include <stdbool.h>
 
typedef struct Ingredient {
    const char *name;
    float lower, upper;
    float amount;
} Ingredient;
 
int main()
{
    Ingredient ingred[] = {
        { "pepper", 1.5,  3.50, 0 },
        { "salt",   5.5, 13.00, 0 },
        { "garlic", 2.0,  4.00, 0 },
        { "thyme",  0.5,  1.25, 0 }
    };
    int len = sizeof ingred / sizeof ingred[0];
 
    printf("Lets cook!\n");
    printf("====================\n");
 
    for (int i = 0; i < len; ++i) {
        printf("Amount of %s added? ", ingred[i].name);
        scanf("%f", &ingred[i].amount);
    }
 
    bool okay = true;
    for (int i = 0; i < len; ++i) {
        if (ingred[i].amount < ingred[i].lower) {
            printf("Needs more %s\n", ingred[i].name);
            okay = false;
        }
        else if (ingred[i].amount > ingred[i].upper) {
            printf("Too much %s\n", ingred[i].name);
            okay = false;
        }
    }
 
    if (okay)
        printf("Delicious!\n");
 
    return 0;
}