working on a project, hey forum, it's good to be back, computer programming problem

[_jamie]

#include <stdio.h>
#include <string.h>
#include <stdlib.h>


#define GUESS_COUNT 3



https://kodekata.net/hangman.html

int main()
{
    int a = 0;
    char word[13] = {'h', 'i', 'd', 'd', 'e', 'n', 's', 't', 'r', 'i', 'n', 'g'};
    char new_str[131313];
    int penalty = 0, length;
    int i = 0;


    /* Game is started with a word */


    length = strlen(word);


    printf("%s:\n Length of string: %d\n", word, length);


    for (i = 0; i < 26; i++)
    {
        new_str[i] = word[i];
    }


    for (i = 0; i < 26; i++)
    {
        new_str[i] = word[i];  // copy word[i] into new_str[i]
        printf("%c", new_str[i]);
    }


    printf("\n");


    char scan_string;
    int ascii = scan_string;
    // word[i] is char array


    while (a < GUESS_COUNT) // loop 3 times
    {
        printf("Enter letter: ");
        scanf("%c", &scan_string);


        /* create variable for scan_string 1 between 26 */


        for (i = 65; i < 90; i++) // If letter is in word, all instances revealed
        {
            if (new_str[i] == ascii) // Was found in search
            {
                //printf("Found: %c\n", new_str[i]);
                printf("Found value: %c\n", scan_string);
            }


            else
            {
                printf("Value Not found\n");
                ++penalty;
                break;
            }    
        }
        a++;
    }




    return 0;
}

I've been on the forum a few years now, please, not that hard of a problem, couple questions for my loop, wanted to paste it, it's from link from Hangman | Implement hangman game. attached. Could someone please help fix code attached, also is a loop good, with an if() and else() included for the program. I have only worked on a few steps of the program. Also, I have moved onto to building full Python GUI (Tkinter) programs on past C on Debian linux, that's where I have been. This was built on GCC Debain, i am reading about perl, buffer overflows too, and front & back end development on visual studio now, it's been 4 years since learning C and I am starting a career.

[G4143]

Well number 1:

char word[13] = {'h', 'i', 'd', 'd', 'e', 'n', 's', 't', 'r', 'i', 'n', 'g'};

Do you really want to take the strlen of word?

[john.c]

@G4143, Remember that if you set the first few members of an array, the remaining members will be set to zero. So the string is valid since it is sized to be one element longer than the explicitly set elements. Still, the proper way to do it would be more like:

char word[] = "hiddenstring"; // the size of the array is set automatically

Or perhaps even:

const char *word = "hiddenstring";

More problematic is that he is accessing the array outside it's bounds. E.g.,

for (i = 0; i < 26; i+)
    new_str[i] = word[i]; // indices for word only go from 0 to 12

Inexpicably, he does that twice.
And then, bizarrely:

for (i = 65; i < 90; i++) // WTF?!

None of it makes sense.

[stahta01]

scanf("%c", &scan_string);

The above likely needs to be

scanf(" %c", &scan_string);

The space results in white spaces being skip on input.

But, the OP needs to fix the other issues, also.

Tim S.

[G4143]

@G4143, Remember that if you set the first few members of an array, the remaining members will be set to zero. So the string is valid since it is sized to be one element longer than the explicitly set elements.

Didn't know that! Thanks for pointing that out.

[john.c]

Didn't know that! Thanks for pointing that out.

It's particularly useful for initializing an entire array to 0. E.g.,

    int a[1000] = { 0 }; // zeroes entire array