Thread: How to pass values to elements in array of structs?

Originally Posted by slove

I have 2 structs in a "patient records" database program. I have a function for adding new patients that checks if there's an empty element in the patient array, and if so, goes to a function that finds the next patient number.

When I use my 'viewing records' function, the new patient number is there, rather there's some random numbers. And my strings either aren't there or are a single character. I'm probably making some very obvious assignment errors here:

Code:

void addPatient(struct Patient patient[], int max) { 
int i = 0, index = 0, vacancy = 0, nextNum; 
for (i = 0; !vacancy || i < max; i++) { 
if (patient[i].patientNumber == 0) { 
vacancy = 1; index = i; 
} 
} if (vacancy) { 
patient[index].patientNumber = nextPatientNumber(patient, max); 
// is this right? ^^^^^^^^^ 
inputPatient(patient + index); 
printf("\n*** New patient record added ***\n"); 
   } else { 
printf("\nERROR: Patient listing is FULL!\n"); 
  } return; 
}

void inputPatient(struct Patient* patient) { 
char name[30] = { 0 }; 
printf("Number: %05d", patient->patientNumber); // << works! 
printf("\nName : "); 
scanf("%[^\n]", name); 
strcpy(patient->name, name); // << only copying 1 char 
inputPhoneData(patient); 
return; }


void inputPhoneData(struct Phone* phone) // not the whole function {
 int select, i, valNum = 1; char phoneNum[11] = { 0 }; 
strcpy(phone->description, "TBD"); // << doesnt work. why?? return; }

View this Wikipedia page on indentation styles. Choose one and be consistent. Many programmers editors and IDE's have options for automatically formatting your code, and conforming to a specific style.

I've looked past the code formatting...

Have a look at inputPhoneData()'s parameter:

Code:

void inputPhoneData(struct Phone* phone)

Now have a look at when you call it:

Code:

    inputPhoneData(patient);

Why do you have "patient" there?

Originally Posted by john.c

@hamster, Probably a typo in posting since that code wouldn't compile and yet problems like "only copying 1 char" are runtime problems.

True, bit if they did manage to get things to compile, then they don't have warnings enabled, and this will definitely be an issue.

I always like to think the best of people unless proven otherwise - In this case I wouldn't be surprised if it is a student struggling to learn to code using a cell phone and an online C complier web page.

Well, at least I hope it is!