Thread: Need help with code

So I'm practicing structures and passing parameters in functions, and I'm trying to make a simple program where you choose between Mage, Warrior, and Healer classes. After choosing one, you enter your level, then if you are equal to or over lvl 15, you can choose to buy a weapon specially designed for each class. Then you enter the amount of gold you have, which the program then converts to in game gold (which I named PD), and if you have sufficient funds, you can buy it.

I've only done Mage, and I wanted to test run it, and it first asks me to choose a class. Then when I do, the program just exits.
What did I do wrong? (Sorry, it's kinda long)

Instead of calling the mageWeapon function in the main function, you declared it.

By the way, next time post your code in code tags instead of posting images.

Originally Posted by laserlight

Instead of calling the mageWeapon function in the main function, you declared it.

By the way, next time post your code in code tags instead of posting images.

How exactly do you do that? I tried putting "void mageWeapon(float amount); " right under int main, but it still did the same thing.
And yes, I tried putting it in code tags but copying and pasting from xCode brought up all the color tags too so it just got way too messy, so I decided to SS it.

Originally Posted by leopoldo100

How exactly do you do that? I tried putting "void mageWeapon(float amount); " right under int main, but it still did the same thing.

This is a declaration of the function named mageWeapon:

Code:

void mageWeapon(float amount);

it tells the reader what is the function name, parameter types, and return type. You have also used it to indicate the parameter names, which is a good thing as long as it is consistent with the function definition, which looks like this:

Code:

void mageWeapon(float amount)
{
    /* ... */
}

the function definition is the declaration of the function that also tells the reader what is the implementation of the function.

This is a function call:

Code:

mageWeapon(amount);

it tells the reader the name of the function that is called as well as the names of the arguments that are passed to the function. In fact, you wrote this in the definition of the mageWeapon function, which makes it a recursive call. In this case, such a recursive call is almost certainly a mistake.

Originally Posted by leopoldo100

And yes, I tried putting it in code tags but copying and pasting from xCode brought up all the color tags too so it just got way too messy, so I decided to SS it.

There should be an option to paste as plain text (or to copy as plain text). Xcode is a famous IDE, so it should support such a simple thing.

Your player info is all wrong.

Code:

typedef enum { mage, warrior, healer } role;
typedef struct {
  role role;
  char name[20];
  int level;
} player;

Which you can then initialise with something like

Code:

player newPlayer(void) {
  player p;
  int role;
  scanf("%d",role);
  if ( role == 1 ) p.role = mage;
  // etc
  scanf("%s",p.name);
  p.level = 1;
  return p;
}

Originally Posted by laserlight

This is a declaration of the function named mageWeapon:

Code:

void mageWeapon(float amount);

it tells the reader what is the function name, parameter types, and return type. You have also used it to indicate the parameter names, which is a good thing as long as it is consistent with the function definition, which looks like this:

Code:

void mageWeapon(float amount)
{
    /* ... */
}

the function definition is the declaration of the function that also tells the reader what is the implementation of the function.

This is a function call:

Code:

mageWeapon(amount);

it tells the reader the name of the function that is called as well as the names of the arguments that are passed to the function. In fact, you wrote this in the definition of the mageWeapon function, which makes it a recursive call. In this case, such a recursive call is almost certainly a mistake.


There should be an option to paste as plain text (or to copy as plain text). Xcode is a famous IDE, so it should support such a simple thing.

Thanks for your reply.
I tried to change it to "mageWeapon (amount);", but it's coming up with an error saying "Use of undeclared identifier 'amount' ". Sorry, I am very new to programming so I need a little explanation on this if you can. I think my understanding of creating and calling functions is completely wrong.

This is what I have so far. I didn't include the rest of the code here since it's the same.

Code:

#include <stdio.h>
#include <stdlib.h>


typedef enum { mage, warrior, healer } role;
typedef struct {
    
    role role;
    char name[25];
    int level;
    
}player;


char confirm;
void question(void);
void mageWeapon(float amount);


player p;


int main () {
    int a;
    
    printf("Welcome player. Please enter your class type:");
    printf("\n1) Mage \t2) Warrior \t3) Healer");
    scanf("%d", &a);
    if (a == 1) {
        
        p.role = mage;
        mageWeapon(amount); //error is occurring here
        
    }

Looks good so far with the enum.

In main, you need to call the function with a value.

Code:

int main () {
    int a;
     
    printf("Welcome player. Please enter your class type:");
    printf("\n1) Mage \t2) Warrior \t3) Healer");
    scanf("%d", &a);
    if (a == 1) {
         
        p.role = mage;
        mageWeapon(42.0); //error is occurring here
         
    }

Originally Posted by leopoldo100

Do you know how I would have it so that whatever amount you enter becomes the value the function calls? Because essentially I want it so that the program asks the player (me) for the amount of current gold I have, and I enter the amount, then the program converts it to RP currency. I wrote this code in the void mageWeapon function. What should I put in the brackets for this function call?

Ah, but that implies that amount should not be passed as an argument. You probably want to make it a local variable in mageWeapon instead.