Thread: I can't spot my mistake...

Originally Posted by Hodor

Still won't build for me

Code:

$ make --version
GNU Make 4.2.1
$ gcc --version
gcc (Ubuntu 9.3.0-10ubuntu2) 9.3.0

$ make debug run
.
.
Finished checking
PRJ_DST_BIN=alu_d.AppImage
PRJ_DST_LIB=libalu_d.so
cc -ggdb -D _DEBUG -fPIC -shared -Wall -Wextra -I cloned/fbstdc/include  -o test_d.o -c test.c
cc -ggdb -D _DEBUG -fPIC -shared -Wall -Wextra -I cloned/fbstdc/include  -o alu_vec_d.o -c alu_vec.c
cc -ggdb -D _DEBUG -fPIC -shared -Wall -Wextra -I cloned/fbstdc/include  -o alu_mem_d.o -c alu_mem.c
cc -ggdb -D _DEBUG -fPIC -shared -Wall -Wextra -I cloned/fbstdc/include  -o alu_bit_d.o -c alu_bit.c
cc -ggdb -D _DEBUG -fPIC -shared -Wall -Wextra -I cloned/fbstdc/include  -o alu_math_d.o -c alu_math.c
cc -ggdb -D _DEBUG -fPIC -shared -Wall -Wextra -I cloned/fbstdc/include  -o alu_int_d.o -c alu_int.c
cc -ggdb -D _DEBUG -fPIC -shared -Wall -Wextra -I cloned/fbstdc/include  -o alu_main_d.o -c alu_main.c
cc -ggdb -D _DEBUG -fPIC -shared -Wall -Wextra -I cloned/fbstdc/include  -o alu_uint_d.o -c alu_uint.c
cc -ggdb -D _DEBUG -fPIC -shared  -o libalu_d.so alu_vec_d.o alu_mem_d.o alu_bit_d.o alu_math_d.o alu_int_d.o alu_main_d.o alu_uint_d.o -Wl,-rpath=./
cc -ggdb -D _DEBUG -fPIE -L . -l alu_d  -o alu_d.AppImage test_d.o -Wl,-rpath=./
/usr/bin/ld: test_d.o: in function `uint_compare':
/home/hodor/tmp/alu/test.c:39: undefined reference to `alu_uint_cmp'
/usr/bin/ld: test_d.o: in function `int_compare':
/home/hodor/tmp/alu/test.c:84: undefined reference to `alu_int_cmp'
/usr/bin/ld: test_d.o: in function `reg_compare':
/home/hodor/tmp/alu/test.c:113: undefined reference to `alu_get_regv'
.
.
/home/hodor/tmp/alu/test.c:1368: undefined reference to `alu_setup_reg'
/usr/bin/ld: /home/hodor/tmp/alu/test.c:1388: undefined reference to `alu_vec'
/usr/bin/ld: /home/hodor/tmp/alu/test.c:1389: undefined reference to `alu_vec'
collect2: error: ld returned 1 exit status
make[1]: *** [main.mak:89: alu_d.AppImage] Error 1
make: *** [1st.mak:6: debug] Error 2

You probably have old objects there, add rebuild to the target list then do normally, I haven't figured out why make is not rebuilding objects as it ought to, feel free to investigate that later, not my primary concern at the moment

Originally Posted by awsdert

You probably have old objects there, add rebuild to the target list then do normally, I haven't figured out why make is not rebuilding objects as it ought to, feel free to investigate that later, not my primary concern at the moment

Unfortunately not (I did make clean first). But, just to make sure I deleted the directory and re-cloned your repo... exactly the same result as above

Originally Posted by Hodor

Unfortunately not (I did make clean first). But, just to make sure I deleted the directory and re-cloned your repo... exactly the same result as above

That's weird, the 1st 2 are defined right at the top of their relative files (alu_uint.c & alu_int.c), the 3rd is in alu_main.c right under alu_get_reg()... AH! Check if libalu_d.so still exists in your directory, it may have been 'cleaned' somehow

Originally Posted by awsdert

That's weird, the 1st 2 are defined right at the top of their relative files (alu_uint.c & alu_int.c), the 3rd is in alu_main.c right under alu_get_reg()... AH! Check if libalu_d.so still exists in your directory, it may have been 'cleaned' somehow

Yeah it built libalu_d.so ok (it's in the directory); it's not linking though

Code:

$ ls
1st.mak      alu.h        alu_int_d.o   alu_math_d.o  alu_uint_d.o  cloned       libalu_d.so  test_d.o
GNUmakefile  alu_bit.c    alu_main.c    alu_mem.c     alu_vec.c     dst_cc.mak   main.mak
LICENSE      alu_bit_d.o  alu_main_d.o  alu_mem_d.o   alu_vec_d.o   dst_sys.mak  makefile
README.md    alu_int.c    alu_math.c    alu_uint.c    char.mak      func.mak     test.c

Originally Posted by Hodor

Yeah it built libalu_d.so ok (it's in the directory); it's not linking though

Code:

$ ls
1st.mak      alu.h        alu_int_d.o   alu_math_d.o  alu_uint_d.o  cloned       libalu_d.so  test_d.o
GNUmakefile  alu_bit.c    alu_main.c    alu_mem.c     alu_vec.c     dst_cc.mak   main.mak
LICENSE      alu_bit_d.o  alu_main_d.o  alu_mem_d.o   alu_vec_d.o   dst_sys.mak  makefile
README.md    alu_int.c    alu_math.c    alu_uint.c    char.mak      func.mak     test.c

Strange, I honestly suck at makefiles (despite using them in every project) so I don't know what to do about that, as far as I can see gcc should find it without issue as the directory itself is included via the '-L .' and the library should've been correctly referenced via '-l alu_d', if you got any ideas just give it a try, let me know if something causes it to link, I'll incorporate it into mine and upload it

Originally Posted by hamster_nz

Hi,

I did clone your repo, and tried building it with just "make" and had no success:

Code:

....
test.c:(.text+0x4529): undefined reference to `alu_str2int'
test.c:(.text+0x45c7): undefined reference to `alu_int2str'
test.c:(.text+0x46a3): undefined reference to `alu_rem_reg_node'
test.o: In function `print_value':
test.c:(.text+0x48d4): undefined reference to `alu_block'
test.c:(.text+0x4c22): undefined reference to `alu_block'
test.c:(.text+0x4d78): undefined reference to `alu_block'
test.o: In function `main':
test.c:(.text+0x4e55): undefined reference to `alu_setup_reg'
test.c:(.text+0x4ffc): undefined reference to `alu_vec'
collect2: error: ld returned 1 exit status
main.mak:91: recipe for target 'alu.AppImage' failed
make[3]: *** [alu.AppImage] Error 1
1st.mak:6: recipe for target 'build' failed
make[2]: *** [build] Error 2
main.mak:68: recipe for target 'all' failed
make[1]: *** [all] Error 2
1st.mak:6: recipe for target 'all' failed
make: *** [all] Error 2

So I short-cut it all:

Code:

~/alu$ gcc -o alu *.c -I cloned/fbstdc/include
~/alu$

I now also get your issue:

Code:

:~/alu$ ./alu
test.c:1341: main() Pre-allocating 32 ALU registers...
test.c:698: compare() 'Comparing values...'
test.c:699: compare() '==========================================='
*** stack smashing detected ***: <unknown> terminated
Aborted (core dumped)

So now I compiled with warnings turned up to 11:

Code:

gcc -o alu *.c -I cloned/fbstdc/include -Wall -pedantic -O4

I get 556 lines of warning where dodgy stuff is going on. You really want to fix all of thoses before you start any serious debugging.

But seriously: I'm more then willing to help you get this into shape, but do you really want my help?

I do know a bit of this stuff - if you want, have a look at my toy RISCV RV32I CPU's ALU.

Rudi-RV32I/alu.vhd at master * hamsternz/Rudi-RV32I * GitHub

I actually forgot that flag existed, considering the type of project it is there's no real reason for me to not add it in and leave it there permanently, already helping me identify a bunch of bugs introduced while I was changing the core API, dealing with them now, some on the other hand are minor and safe to ignore (fixing 'em anyways though)

Originally Posted by Hodor

Yeah it built libalu_d.so ok (it's in the directory); it's not linking though

Code:

$ ls
1st.mak      alu.h        alu_int_d.o   alu_math_d.o  alu_uint_d.o  cloned       libalu_d.so  test_d.o
GNUmakefile  alu_bit.c    alu_main.c    alu_mem.c     alu_vec.c     dst_cc.mak   main.mak
LICENSE      alu_bit_d.o  alu_main_d.o  alu_mem_d.o   alu_vec_d.o   dst_sys.mak  makefile
README.md    alu_int.c    alu_math.c    alu_uint.c    char.mak      func.mak     test.c

AH! Just a thought, try removing the 'lib' part from the library name, maybe your system doesn't prepend that when searching

Originally Posted by awsdert

Well I tried adding the profiling as a target/goal, as you might have guessed I didn't succeed:

Code:

make profile run
MAKECMDGOALS=profile run
make -j 1 --no-print-directory -f main.mak profile run
PRJ_SRC_FILES = 'test.c alu_bit.c alu_int.c alu_main.c alu_math.c alu_mem.c alu_uint.c alu_vec.c'
Checking 3rd Party libraries are upto date
cd 'cloned/fbstdc' && git config pull.rebase true && git pull
Already up to date.
Finished checking
PRJ_DST_BIN=alu_p.AppImage
PRJ_DST_LIB=libalu_p.so
make[1]: Nothing to be done for 'profile'.
gprof ./alu_p.AppImage
gmon.out: No such file or directory
make[1]: *** [main.mak:83: run] Error 1
make: *** [1st.mak:6: profile] Error 2
Compilation failed.

Any ideas why it failed?

Can't see it compiling any of the -c- source with "-pg" in that output.