Encountering an infinite loop, unsure as to why

[JMerritt]

Hello all, recently I've been working on a HashTable data structure and have attempted to make it work for a project. Currently, I am encountering an infinite loop when I make it about two lines deep into the input file I need to parse through. From what I can surmise, my functions for key creation and inserting into the hash table are not the issue, but it may be how I'm parsing through the lines of my input file. I cannot see the fault in my logic that's causing the issue but I hope you may be able to help me. I'm currently just trying to get past reading and inserting the names from the input file so some of the comments in main are irrelevant, I will also attach the files to this post in zip file. Here is my code for main.

#include "HashTable.h"
#include <string.h>
#define MAX_LINE_LENGTH 100

int main()
{
    //create hash table size 100
    //open file nbaTeamNames.csv
    //read in each team name by line and use put to write an element for
    //the team with intial wins and loss of 0
    //open file nbaData2019
    //read by line and determine a winner and loser
    //use get function to obtain element associated with team and increment
    //wins and losses accordingly
    //after all lines read, reopen nbaTeamNames.csv
    //print out team name and win loss count per line
    //use get function to get win loss count
    //Print result should look like
    //"San Antonio Spurs: XX Wins - XX Losses"
    HashTable Hash = newHashTable(100);
    Element tempElm;
    Element *e;
    FILE *inputFile;
    inputFile = fopen("nbaTeamNames.csv", "r");
    if(inputFile == NULL){

  perror("Error opening file");
  return -1;
    }
    
    char nextLine[MAX_LINE_LENGTH];
    char currLine[MAX_LINE_LENGTH];
    
    while(fgets(nextLine, MAX_LINE_LENGTH, inputFile)!= NULL){
        int deli = strlen(nextLine) - 1;
        if(nextLine[deli] == '\n'){
            nextLine[deli-1] = '\0';
        }
        sscanf(nextLine, "%[^\n]\n", currLine);
        strcpy(tempElm.szTeamName, currLine);
        tempElm.losses = 0;
        tempElm.wins = 0;
        put(Hash, tempElm);
        printf("%s\n", tempElm.szTeamName); 
    }
    fclose(inputFile);
    
    return 0;
}

[stahta01]

        if(nextLine[deli] == '\n'){
            nextLine[deli-1] = '\0';
        }

Why are you setting nextLine[deli-1] to '\0' ?
Instead of nextLine[deli] ?

Tim S.

[JMerritt]

Ah, it was because I was attempting to get the carriage return character at the end of the lines of my input file. I've since updated the declaration to be as such:

i= 0;
while(nextLine[i] != '\r' && nextLine[i] != '\n' && nextLine[i] != '\0')
     i++;


if(nextLine[i] == '\r' || nextLine[i] == '\n')
     nextLine[i] = '\0';

However, I still encounter my glaring issue.

[stahta01]

Better in my viewpoint is.

Edit: But, yours looks as good; I just try to avoid loops when I think they are not needed.

if(nextLine[deli] == '\n' || nextLine[deli] == '\r'){
    nextLine[deli] = '\0';
    if(nextLine[deli-1] == '\n' || nextLine[deli-1] == '\r'){
        nextLine[deli-1] = '\0';
    }
}

[stahta01]

Did you try commenting out the "put(Hash, tempElm);" call?

Tim S.

[stahta01]

I would replace "strcpy" with "strncpy" because it is safer and might be the cause of your issue.

Tim S

[JMerritt]

I attempted your first suggestion and unfortunately it yielded much of the same results. omitting put(Hash, tempElm) will get all of the team names but will not insert those names into the hashTable. What would you suggest I set the buffer size of strncpy to be?

[laserlight]

What is your current code?

[stahta01]

    char nextLine[MAX_LINE_LENGTH];
    char currLine[MAX_LINE_LENGTH];

To be safe use

    char nextLine[MAX_LINE_LENGTH+1];
    char currLine[MAX_LINE_LENGTH+1];

    nextLine[MAX_LINE_LENGTH] = '\0';
    currLine[MAX_LINE_LENGTH] = '\0';

Tim S.

[JMerritt]

Sorry to do this but I had reached out to a colleague and he'd pointed out that my newHashTable function had a flaw that was making my hash table matrices be of array size int instead of array size HashTableEntry. My issue has since been resolved. Thank you for your input's!