Thread: Search through file and print an IP

Originally Posted by john.c

Code:

void scan_ipconfig() {
    const char *terms[] = {
        "IPv4",
        "subred",
        "Puerta",
        "Servidores DNS",
        NULL
    };
    FILE *f = popen("ipconfig /allcompartments /all", "r");
    char line[256];
    while (fgets(line, sizeof line, f))
        for (const char **p = terms; *p; ++p)
            if (strstr(line, *p))
                fputs(line, stdout);
    pclose(f);
}

Thanks! That works like a charm, much appreciated!

Actually, for this very module I need to filter the adapters shown by ipconfig /allcompartments /all and offer some kind of menu to select one of them and show such properties. A friend suggested a constructor which accumulates the position of each one, but I don't really understand the approach - also, and the most trivial yet scary thing, I don't know which command I should use to extract and separate info from each adapter or how to do that - maybe stop reading after each \n\n? Honestly, I don't know...

Originally Posted by john.c

Maybe try something like this.

Code:

void ping(const char *ip) {
    char ping_cmd[256];
    sprintf(ping_cmd, "ping %s", ip);
    FILE *f = popen(ping_cmd, "r");  // popen is a posix function
    while (fgets(line, sizeof line, f))
        if (strstr(line, term))
            printf("\n\n   IP responde positivamente: %s", ip);
    pclose(f);
}

As for this part, I'm showing how it looks like in my implementation. I'm having a hard time at reading the whole external .txt (variable x), which consists on different lines of IP's, one above the other. I need to read them all and cast a printf whether they get a positive response or not:

Code:

void seleccionarArchivo()
{
    FILE* fp, * fp2;
    char ch[500], x[500], str[500], line[BUFSIZ];
    char term[20] = "Media"; // Línea de caracteres de búsqueda para remarcar IP's que respondan positivamente
    char ping_cmd[256];

    printf("\n    Escribe la ruta del documento deseado\n\n");
    scanf("%s", x);

    fp = fopen(x, "r");
    if (fp == NULL)
    {
        printf("\n    El archivo no se ha podido encontrar\n\n");
        exit(0);
    }
    // Bloque que printa el contenido del archivo donde están las IP's
    while (fgets(ch, sizeof(ch), fp))
    {
        printf("%s", ch);
    }
    fclose(fp);

    // Bloque que analizará las IP's que responden positivamente
    sprintf(ping_cmd, "ping %s", ch);
    FILE* f = _popen(ping_cmd, "r");
    while (fgets(line, sizeof line, f))
        if (strstr(line, term))
            printf("\n\n   The IP responds: %s", ch);
        else("\n\n   The IP %s does not respond", ch);
    _pclose(f);
}

I don't know if that's possible without redirecting the results to an external file (as I did quite sloppily before), but this way you suggested looks neater. Only if I'd be able to fulfill the whole iteration..., it seems like it just skips the first line for some weird reason still. Nor even my teacher knows why (not that he seems much interested...).

Originally Posted by Salem

Well as written, you're only going to ping the last line of the file.

Wow, much better, thanks a whole damn lot! Had to remove the "else {" part, since it printed the other string for each line read by the pointer and looked annoying. Would it be a clean way to print "The IP %s does not respond" AFTER the ping's concluded (i.e. the line's been read and the term variable doesn't appear)? Once again, THANKS a lot. I'm learning much more here than with my teacher's correspondence, that's for sure.

P.D. Also, printing the contents of the external file refered to by variable x would be ace, just before launching the pings. But, to be honest, it's less important.

Ha, sorry for my insistence. I've reworked my code, implementing john.c's instead of that of the previous post (which proved to be a bit problematic). So far:

Code:

#define _CRT_SECURE_NO_WARNINGS
#include <winsock2.h>
#include <iphlpapi.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#pragma comment(lib, "IPHLPAPI.lib")

void main(void) {

    char termAdaptador[BUFSIZ] = "Adaptador";
    char* p, * p2;
    char str[100], line[256];
    const char* terms[] = {
    "IPv4",
    "subred",
    "Puerta",
    "Servidores DNS",
    NULL
    };

    // Redirection to ip.out.txt in order to gather the info I want
    strcpy(str, ">> ip.out.txt ");
    strcat(str, "ipconfig /allcompartments /all");
    system(str);

    // Listing the adapters
    FILE* f = _popen("ipconfig /allcompartments /all", "r");
    printf("\n    Available adapters:\n\n");
    while (fgets(line, sizeof line, f)) {
        if (strstr(line, termAdaptador) != NULL)
            printf(line);
    }

    // Scanf to choose my adapter and display its info
    printf("Write down the adapter: ");
    scanf("%s", line); // Is it right?

     // Here I want to print the detailed info I extracted off the adapter, i.e. IP, submask, gateway and DNS servers.
    while (fgets(line, sizeof line, f))
        for (const char** p = terms; *p; ++p)
            if (strstr(line, *p))
                fputs(line, stdout);
  

}

Now I'm having trouble extracting such info off the file and printing it right. My ip.out.txt looks like this, to get an idea:

Code:

Adaptador de Ethernet Ethernet:

   Sufijo DNS espec¡fico para la conexi¢n. . : 
   Descripci¢n . . . . . . . . . . . . . . . : Realtek XXXXX
   Direcci¢n f¡sica. . . . . . . . . . . . . : XXXXXXXXXXXXXXXXXX
   DHCP habilitado . . . . . . . . . . . . . : s¡
   Configuraci¢n autom tica habilitada . . . : s¡
   V¡nculo: direcci¢n IPv6 local. . . : XXXXXXXXX(Preferido) 
   Direcci¢n IPv4. . . . . . . . . . . . . . : XX.XX.XX.XX(Preferido) 
   M scara de subred . . . . . . . . . . . . : XXXXXX
   Concesi¢n obtenida. . . . . . . . . . . . : lunes, 11 de mayo de 2020 7:46:16
   La concesi¢n expira . . . . . . . . . . . : martes, 12 de mayo de 2020 1:46:15
   Puerta de enlace predeterminada . . . . . : 192.168.1.1
   Servidor DHCP . . . . . . . . . . . . . . : 192.168.1.1
   IAID DHCPv6 . . . . . . . . . . . . . . . : XXXXXXXXX
   DUID de cliente DHCPv6. . . . . . . . . . : XXXXXXXXX
   Servidores DNS. . . . . . . . . . . . . . : XXXX
                                       XXXXXX
   NetBIOS sobre TCP/IP. . . . . . . . . . . : habilitado

Adaptador de LAN inal mbrica Wi-Fi:

   Estado de los medios. . . . . . . . . . . : medios desconectados
   Sufijo DNS espec¡fico para la conexi¢n. . : 
   Descripci¢n . . . . . . . . . . . . . . . : Qualcomm Atheros XXXXXXXXX
   Direcci¢n f¡sica. . . . . . . . . . . . . : XXXXXXX
   DHCP habilitado . . . . . . . . . . . . . : s¡
   Configuraci¢n autom tica habilitada . . . : s¡

Sorry for the annoyance, but after some time of struggle I think I'm almost there and it's annoying indeed not finding how...

So now I have:

Code:

#define _CRT_SECURE_NO_WARNINGS
#include <stdio.h>
#include <stdlib.h>
#include <string.h>

char extraer_info(const char* adaptador);

void main(void) {
    FILE* fp;
    char termAdaptador[BUFSIZ] = "Adaptador";
    char* p, * p2;
    char str[100], line[256], adaptador[100];
    const char* terms[] = {
    "IPv4",
    "subred",
    "Puerta",
    "Servidores DNS",
    NULL
    };

    // Redirection to ip.out.txt in order to gather the info I want
    strcpy(str, "> ip.out.txt ");
    strcat(str, "ipconfig /allcompartments /all");
    system(str);

    // Listing the adapters
    fp = fopen("ip.out.txt", "r");
    printf("\n    Los adaptadores de red disponibles son los siguientes:\n\n");
    while (fgets(line, sizeof line, fp)) {
        if (strstr(line, termAdaptador) != NULL)
            printf(line);

    }

    // Scanf to choose my adapter and display its info
    printf("Escribe el adaptador deseado: ");
    scanf("%s", adaptador);
    printf("\n\n");
    char adapt_info = extraer_info(adaptador); // I've created the function to scanf the name of the adapter among those that've been listed
}

char extraer_info(const char* adaptador)
{
    FILE* fp;
    const char* const Delim = "Adaptador"; // I want to find the string of letters that coincides with my variable "adaptador" to position my pointer there, don't know how to
    const char* terms[] = {
    "IPv4",
    "subred",
    "Puerta",
    "Servidores DNS",
    NULL
 };

    fp = fopen("ip.out.txt", "r");
    char line[256];
    while (fgets(line, sizeof line, fp))
        for (const char** p = terms; *p; ++p)
            if (strstr(line, *p))
                fputs(line, stdout); // That's messy indeed. I want to scan through the opened file (that looks like the one I've pasted just before) and find the string referred by the variable "adaptador" to extract the paragraph that follows, until the next \n\n, and be able to print its specs properly.

    //exit(EXIT_FAILURE); // OK, some work needs to be done but not worried about that bit.
    return 0;
}

Sloppy, I know, but I think it would do the trick. So I need those final touches I'm unable to find out..., thanks in advance!

Guess who's back...
I need a slight modification of this piece for a different program.

Originally Posted by Salem

Well as written, you're only going to ping the last line of the file.

Code:

    while (fgets(ch, sizeof(ch), fp))
    {
        printf("%s", ch);

        sprintf(ping_cmd, "ping %s", ch);
        FILE* f = _popen(ping_cmd, "r");
        while (fgets(line, sizeof line, f)) {
            if (strstr(line, term)) {
                printf("\n\n   The IP responds: %s", ch);
            } else {
                printf("\n\n   The IP %s does not respond", ch);
            }
        }
        _pclose(f);

    }
    fclose(fp);

Instead of printing "The IP responds...", I should redirect the IP whose ping has shown success in returning "term" to a temporary file (for the time being I'm toying with a regular one in order to check if it works). Now, what I have so far:

Code:

    fp = fopen(x, "r");
    while (fgets(ch, sizeof(ch), fp))
    {
        printf("Launching ping over %s", ch);

        sprintf(ping_cmd, "ping %s", ch);
        FILE* f = _popen(ping_cmd, "r");
        while (fgets(line, sizeof line, f)) {
            if (strstr(line, term)) {
                sprintf(ping_cmd, "> ips_responden.txt", ch);
            }
        }
        _pclose(f);
    }
    fclose(fp);

I guess my error dwells on the latter "sprintf", for the while loop pings successfully on the console but doesn't return any output file with such "working" IP's listed therein...

As for the temporary file, would it be really messy to transform? I'm reading some info but I want to have my tasks straight before I'm even trying.

Cheers!

Thanks a lot once again, Salem. Worked perfectly. Now my code looks like this:

Code:

    fp = fopen(x, "r");
    FILE* responses = fopen("ips_responden.txt", "w"); // FILE* tmp = tmpfile(); 
    while (fgets(ch, sizeof(ch), fp))
    {
        printf("Lanzando ping sobre %s", ch);
        sprintf(ping_cmd, "ping %s", ch);
        FILE* f = _popen(ping_cmd, "r");
        while (fgets(line, sizeof line, f)) {
            if (strstr(line, term)) {
                fprintf(responses, "%s\n", ch); // fprintf(tmp, "%s\n", ch);
            }
        }
    }
    fclose(fp);

I've commented the lines which I want to implement as a rather temporary file once I get the whole program straight and I'm able to see it's working right as a whole. From what I've gathered, it works like this, i.e. replacing those lines for the bold ones.

Ha, the tmp conversion is troublesome, indeed. I'm following this route:

Code:

FILE* tmp = tmpfile(); 
    while (fgets(ch, sizeof(ch), fp))
    {
        printf("Lanzando ping a %s", ch);
        sprintf(ping_cmd, "ping %s", ch);
        FILE* f = _popen(ping_cmd, "r");
        while (fgets(line, sizeof line, f)) {
            if (strstr(line, term)) {
                fprintf(tmp, "%s\n", ch);
            }
        }
        fclose(f);
    }
    fclose(tmp);
    fclose(fp);

So far, so good, methinks. But then...:

Code:

 // tmp = fopen(tmp, "r"); // How do I open the temporary file? Do I close it at all? It just crashes over and over...
     while (fgets(ipresp, sizeof(ipresp), tmp))
    {
        int response1 = velocidad_media(ipresp);
        printf("\n    Velocidad de respuesta media: %d ms.\n", ipresp, response1);
    }

Here I want to recycle that comparison function I used before, to compare between ping results. This time I don't have a predefined number of IP's to compare, but it depends on the actual IP's that responded well during the previous ping procedure.

Code:

int velocidad_media(const char* ip)
{
    const char* const Delim = "Media = ";
    printf("\n    Extrayendo velocidad media de %s", ip);

    char cmd[64];
    sprintf(cmd, "ping %s", ip);
    FILE* p = _popen(cmd, "r");
    char line[256];
    while (fgets(line, sizeof(line), p))
    {
        char* s = NULL;
        if ((s = strstr(line, Delim)) != NULL)
        {
            _pclose(p);
            return atoi(s + strlen(Delim));
        }
    }
    _pclose(p);

    return -1;
}

Except for the tmp conversion, it works almost fine. Only that I want to get the results for the IP's that got a good response and therefore got saved at the "ips_responden.txt" file (tmp file, this time), and this code includes some annoying line break (I think), so I get the extracted info for the IP AND a weird one that isn't at the .txt file. How do I prevent that?

Still trying to solve my loop but I feel I'm close to it.

Code:

        int best_response = velocidad_media(fgets(ipresp, sizeof(ipresp), responses));
        char best_ip;
        responses = fopen("ips_responden.txt", "r");
        while (fgets(ipresp, sizeof(ipresp), responses))
        {
            int response1 = velocidad_media(ipresp);
            if (response1 < best_response) {
                best_response = response1;
                best_ip = response1;
            }
            printf("\n    Velocidad de respuesta media: %d ms.\n", best_response);
            printf("    IP seleccionada: %s", best_ip);
        }

The implementation of "best_ip" seems the only troublesome issue here. I've already gotten the best_respone but don't know how to store the line that's read when getting such string. Please help and I thiink I'm done!