Thread: stuck on "else if ()" situation, can't figure out the problem. all looks correct.

i wrote this code which gives error to the condition else if. i tried everything. if i remove this part the code works fine.

here is the code

Code:

#include <stdio.h>
#include <math.h>
#include <cs50.h>
int main(void)
{

  float n;
  do {
    // prompt user for change
    n = get_float("change owed: ");
  }
  while (n < 0);
  int cents = round(n * 100);
  // perform division
  // computes quotient
  int quotient = cents / 25;

  // computes remainder
  int remainder = cents % 25;

  printf("Quotient = %d\n", quotient);

  printf("Remainder = %d\n", remainder);

  if (remainder >= 10) {
    int quotient2 = remainder / 10;
    int remainder2 = remainder % 10;
    printf("Quotient2 = %d\n", quotient2);
    printf("Remainder2 = %d\n", remainder2);
    if (remainder2 >= 5) {
      int quotient4 = remainder2 / 5;
      int remainder4 = remainder2 % 5;
      printf("Quotient4 = %d\n", quotient4);
      printf("Remainder4 = %d\n", remainder4);
      int addition, subtraction, multiplication, division, modulus;
      addition = quotient + quotient4 + remainder4;
      printf("number of coins: %d\n", addition);
    } else {
      int addition, subtraction, multiplication, division, modulus;
      addition = quotient + quotient2 + remainder2;
      printf("number of coins: %d\n", addition);
    }

    else
  if (remainder < 10 && >=5) {
    int quotient3 = remainder / 5;
    int remainder3 = remainder % 5;
    printf("Quotient3 = %d\n", quotient3);
    printf("Remainder3 = %d\n", remainder3);
    int addition, subtraction, multiplication, division, modulus;
    addition = quotient + remainder;
    printf("number of coins: %d\n", addition);
  } else {
    printf("%d\n", remainder);
  }
  }

}

thank you in advance for your input.
#

This is why indentation is so important.
If you have lousy indentation, it's too hard to track what belongs where.

Code:

#include <stdio.h>
#include <math.h>
#include <cs50.h>
int main(void)
{
  float n;
  do {
    // prompt user for change
    n = get_float("change owed: ");
  }
  while (n < 0);
  int cents = round(n * 100);
  // perform division
  // computes quotient
  int quotient = cents / 25;
  // computes remainder
  int remainder = cents % 25;

  printf("Quotient = %d\n", quotient);
  printf("Remainder = %d\n", remainder);

  if (remainder >= 10) {
    int quotient2 = remainder / 10;
    int remainder2 = remainder % 10;
    printf("Quotient2 = %d\n", quotient2);
    printf("Remainder2 = %d\n", remainder2);
    if (remainder2 >= 5) {
      int quotient4 = remainder2 / 5;
      int remainder4 = remainder2 % 5;
      printf("Quotient4 = %d\n", quotient4);
      printf("Remainder4 = %d\n", remainder4);
      int addition, subtraction, multiplication, division, modulus;
      addition = quotient + quotient4 + remainder4;
      printf("number of coins: %d\n", addition);
    } else {
      int addition, subtraction, multiplication, division, modulus;
      addition = quotient + quotient2 + remainder2;
      printf("number of coins: %d\n", addition);
    }
    //else
    if (remainder < 10 && >=5) {
      int quotient3 = remainder / 5;
      int remainder3 = remainder % 5;
      printf("Quotient3 = %d\n", quotient3);
      printf("Remainder3 = %d\n", remainder3);
      int addition, subtraction, multiplication, division, modulus;
      addition = quotient + remainder;
      printf("number of coins: %d\n", addition);
    } else {
      printf("%d\n", remainder);
    }
  }
}

You can't have another else at line 40, because you've already got one at line 35.

Originally Posted by SELKERDANY

while the else if in line 40 belongs to the main if in line 22

No, it doesn't. That else is a syntax error. If you do want that else to match up with the very first if, you need to precede it by a closing brace so that the block associated with that if would end.

I just love the innuendo that chopped liver over here made no contribution at all to the proceedings.