Thread: disabling minimize and mazimize boxes on Microsoft display output

I seem to need to define the words "does work". The function is supposed to disable the effects of pressing the minimize and maximize button. So if after implementing the code, pressing the respective buttons still leads to maximizing and minimizing, then the code does not work. I have the code in the list of prototypes at the head of the coding. I call the function from main. The definition of the function 100% as john gave it to me.

The basic function that works is coded like so;

Code:

fbgfxHwnd = GetConsoleWindow()
ws = GetWindowLongPtr( fbgfxHwnd, GWL_STYLE )
SetWindowLongPtr( fbgfxHwnd, GWL_STYLE, ws xor (WS_MAXIMIZEBOX or WS_MINIMIZEBOX) )

If I compare this code to the code that I was given there are some differences.

Yes, I know what a function is.
Yes I know how to call a function.
Yes I called the function form main.
No I am no bloody idiot.

Originally Posted by Ivory348

I seem to need to define the words "does work". The function is supposed to disable the effects of pressing the minimize and maximize button. So if after implementing the code, pressing the respective buttons still leads to maximizing and minimizing, then the code does not work. I have the code in the list of prototypes at the head of the coding. I call the function from main. The definition of the function 100% as john gave it to me.

The basic function that works is coded like so;

Code:

fbgfxHwnd = GetConsoleWindow()
ws = GetWindowLongPtr( fbgfxHwnd, GWL_STYLE )
SetWindowLongPtr( fbgfxHwnd, GWL_STYLE, ws xor (WS_MAXIMIZEBOX or WS_MINIMIZEBOX) )

If I compare this code to the code that I was given there are some differences.

That's not even C but what you were given is more correct; you don't really know the current states of WS_MAXIMIZEBOX and WS_MINIMIZEBOX so using XOR is not a great solution (you should be using AND to clear the bits... XOR toggles them)

Edit: Why are you refusing to show your C code? I'm beginning to suspect you haven't written any C

This is how I changed the code:

Code:

void disableMinimizeAndMaximizeButtons()
{
    HWND hwnd;
    LONG_PTR ws;
    hwnd = GetConsoleWindow();
    ws =  GetWindowLong(hwnd, GWL_STYLE);
    SetWindowLong(hwnd, GWL_STYLE, ws xor (WS_MAXIMIZEBOX or WS_MINIMIZEBOX));
}

Originally Posted by Ivory348

This is how I changed the code:

Code:

void disableMinimizeAndMaximizeButtons()
{
    HWND hwnd;
    LONG_PTR ws;
    hwnd = GetConsoleWindow();
    ws =  GetWindowLong(hwnd, GWL_STYLE);
    SetWindowLong(hwnd, GWL_STYLE, ws xor (WS_MAXIMIZEBOX or WS_MINIMIZEBOX));
}

That's not C (unless you have a #define for xor I guess, but that's crazy)

Yes sir, that is what I am saying

Could you possibly make a suggestion of how, what you say is wrong, should be changed?

Originally Posted by laserlight

Did you get any warning from the compiler? I would expect a warning because it sounds unlikely that GetWindowLong will return a LONG_PTR.

Speaking of that, another thing to investigate is whether there's an equivalent of GetWindowLongPtr in C: a quick check of MSDN docs shows that it may be so, although there seems to be some difference in naming due to a possible name suffix.

This is definitely wrong:

Code:

ws xor (WS_MAXIMIZEBOX or WS_MINIMIZEBOX))

In C, the or operator is an alias for the logical || operator not the bitwise | operator. While xor is an alias for the bitwise ^ operator, you likely have to #include <iso646.h> to be able to use it, which makes it puzzling why you didn't get an error or at least a warning (unless you simply ignored the warning.)

Could you possibly make a suggestion of how, what you say is wrong, should be changed?

Originally Posted by Ivory348

Could you possibly make a suggestion of how, what you say is wrong, should be changed?

She's saying that xor and or are logical operaters (boolean), not bitwise operators. So it should be

Code:

ws ^ (WS_MAXIMIZEBOX | WS_MINIMIZEBOX))

But I still don't understand why

Code:

ws & ~(WS_MAXIMIZEBOX | WS_MINIMIZEBOX)

would not work and that's worrying (to me) because I think the latter is the better approach

[QUOTE=Hodor;1292086]Are you saying that

Code:

void disableMinimizeAndMaximizeButtons()
{
    HWND hwnd;
    LONG_PTR ws;
    hwnd = GetConsoleWindow();
    ws =  GetWindowLong(hwnd, GWL_STYLE);
    SetWindowLong(hwnd, GWL_STYLE, ws & ~(WS_MAXIMIZEBOX | WS_MINIMIZEBOX));
}

does not work? .. . . . . . . no does not work

Originally Posted by laserlight

Yeah, I agree that john.c's formulation of current_value & ~(WS_MAXIMIZEBOX | WS_MINIMIZEBOX) makes more sense. The Basic code does do bitwise operations if the operands are numeric rather than boolean though, but I wonder if LONG_PTR in Basic gets interpreted as numeric instead of boolean in this context. The other issue is the difference between GetWindowLong and GetWindowLongPtr, but I am unfamiliar with this API so I do not know which should be preferred.


I posted that in post #19.

Based on the documentation I can only assume that the LONG_PTR I can only assume is a mistake and maybe messing up the bitwise operations somehow. I can only assume because I don't have a Windows compiler and am just reading the documentation.

I didn't know C had the aliases xor, or, and etc. Probably because I've never looked because I don't find the original operators difficult to understand. Thanks for pointing that out. I don't think I'll ever use them though because they seem more confusing than using, for example, && and &, where it's clear you're using logical or bitwise