struct problem

[Ballazx]

Hi All,

Im very beginner at C but my teacher gave me an excercise and I can not do it. The task is to create a struct called "team". This struct contains a char: "char c", and an int: "int length" and a char array: "nam[10]. I have to write a function named "newteam". The input of the function is string:actually the name of the team.
What this function should do is get the input string, and store it in the "length" and drop the first character of the string into the "char c".
I have this code so far:

#include <stdio.h>
#include <stdlib.h>
typedef struct team_struct *Teams;
typedef struct team_struct{
 char f;
 char nam[10];
 int length;
};


Teams newteam(char *nam){
    Teams s = malloc(sizeof(Teams));
    s->length = strlen(nam);
};
int main() {
    newteam("SomeName");
    printf("%d",team_struct.length);
}

How should I print out the values?

Thanks for your help!

[stahta01]

Your function newteam is missing a return statement.

[cooper1200]

Your function newteam is missing a return statement.

so is main.
newteam also has a superfluous semi colon after the closing bracket

[catacombs]

You don't need to allocate memory on line 12. You can set the character array size on line 5.

[Click_here]

There is a sneaky little bug with "Teams" - Because it is a typedef'd pointer, you need to treat it a little different...



The best way around this is to remove dependency from the type with the malloc

Teams newteam(char *nam){
    // Change this...
    // Teams s = malloc(sizeof(Teams));
    // To this...
    Teams s = malloc(sizeof(*s));

    s->length = strlen(nam);

    strncpy(... /*hint hint*/
 


    return s;
};

The obvious way to avoid problems like this is to not typdef a pointer and just use it as is
i.e.

typedef struct team_struct Teams;
...

Teams *s = malloc(sizeof(*s));