Thread: Why My Code Does not Count The Number Of Lines in the txt file

Here is my CODE:

Code:

int main(){
int numberoflines=0;
char findinglines;
FILE *tabloline;
tabloline=fopen("sporttable.txt","a");
for(findinglines=getc(tabloline);findinglines!=EOF;findinglines=getc(tabloline))
{
    if(findinglines=='\n')
    numberoflines=numberoflines+1;
}
printf("%d",numberoflines);
return 0;
}

Text in the file:



Player G A RC PS
Mehmet Ekinci 9 11 5 10
Volkan Sen 12 8 1 15
Caner Erkin 3 8 2 8
Selcuk Inan 4 8 0 13
Felipo Melo 1 1 0 17

[...]

Originally Posted by kayra09

Code:

    numberoflines=numberoflines+1;

[...]

Yet better is :

Code:

numberoflines++;

Originally Posted by GReaper

You're opening the file for appending("a") instead of reading("r").

IMHO it is better to choose between text or binary file each time. use "rt" to read a text file, "rb" to read a binary file.

More info

Yea I see my mistake now.When I used "r" instead of "a" it kinda worked I guess.I'm getting 5 lines instead of 6.

Originally Posted by ordak

IMHO it is better to choose between text or binary file each time. use "rt" to read a text file, "rb" to read a binary file.

More info

"rt" is needed by Windows compilers to translate the "\r\n" line termination of DOS/Windows text files to a single "\n" char in memory. "bt" make all files binary and no translation occurs.

Linux, UNIX, OS/X, all do not need this translation, as the line termination in text files is simply a newline char, "\n". No distinction is made between "text" or "binary" files in these three O/S's.

Originally Posted by rstanley

"rt" is needed by Windows compilers to translate the "\r\n" line termination of DOS/Windows text files to a single "\n" char in memory. "bt" make all files binary and no translation occurs.

Are you sure Windows needs that? Since fopen is supposed to open a file in "text" mode by default, that would mean Microsoft is not following the standards (again), which really wouldn't surprise me very much.

Originally Posted by kayra09

I'm getting 5 lines instead of 6.

That would be a problem with your input file. Each line must end with the newline character(s)*, otherwise it's an incomplete line**.

* Windows uses "\r\n", and the civilized world (Linux, Mac OS X, etc) uses "\n" as the newline character(s) in text files.

** The newline character(s) should be used as a line terminator, not as a line separator. If it were used as a line separator, a text file with zero lines would look identical to a file with one empty line (i.e., the file would be zero bytes long). Unfortunately, many text editors confusingly display an empty line at the end of the file when the last line is properly terminated, and many people remove the line terminator from the last line to remove that mythical "empty line".

Originally Posted by christop

Are you sure Windows needs that? Since fopen is supposed to open a file in "text" mode by default, that would mean Microsoft is not following the standards (again), which really wouldn't surprise me very much.

I haven't used a Windows compiler for many years, so I don't know, or remember what the default is set to. I was simply explaining that "rt" and "rb" are used in Windows programming, not in other O/S's.