looking at the string of characters in buffer for fgets

**cooper1200** · 05-12-2019

i have the following function that asks the user to input their name. and stores it as one of the members of a struct called player name that can hold upto 10 characters including the \0 character.

Code:

void get_player_names(int num_of_players, Hand *p_player)
{
    int i, x;
    char buff[11];

    for (i = 0; i < num_of_players; i++)
    {
        printf("Please enter player %d's name: ", i + 1);
        x = 0;
        while (x != 1)
        {
            fgets(buff, sizeof(buff), stdin);
            flush_line();
            x = sscanf(buff, "%s", p_player[i].player_name);
            if (x != 1)
            {
                printf("Incorrect Entry\n Please enter player %d's name: ", i + 1);
                x = 0;
            }
        }
    }
}

the issue is i need the buffer to be the same size at least but if i input a shorter name it waits for me to input the remaining characters to fill the buffer.

is there away i can look at each character as it comes in using fgets and search for the newline feed
many thanks
coop

**laserlight** · 05-12-2019

Why do you have the flush_line() call there?

**cooper1200** · 05-12-2019

because i copied the code from another function that reads in a single character and if 10 were entered it printed out invalid entry 10 times so after it read the first character i discarded the rest as not needed. admittedly i don't need it for this function.

**Click_here** · 05-12-2019

Let's say that you want to stop when the user types "grape"

Code:

if (!strcmp (userInput, "grape"))
    break;

**cooper1200** · 05-13-2019

now i get the warning passing argument 1 of strcpy makes makes pointer from integer without cast

Code:

void get_player_names(int num_of_players, Hand *p_player)
{
    int i, x, str_index = 0;
    char buff[2], str_temp[10];

    for (i = 0; i < num_of_players; i++)
    {
        printf("Please enter player %d's name: ", i + 1);
        x = 0;
        while (x != 1)
        {
            fgets(buff, sizeof(buff), stdin);
            if (!strcmp(buff, "\n"))
            {
                strcpy(str_temp[str_index], buff[0]);
                str_index++;
            }
            else
            {
                x = sscanf(str_temp, "%s", p_player[i].player_name);
                if (x != 1)
                {
                    printf("Incorrect Entry\n Please enter player %d's name: ", i + 1);
                    x = 0;
                }
            }
        }
    }
}

what have i done wrong now
coop

**laserlight** · 05-13-2019

Examine the types of the arguments of strcpy. What are the types of the arguments that strcpy expects and what are the types of the arguments that you passed?

Basically, do this whenever you see "makes makes pointer from integer without cast". The message is telling you that you were supposed to pass a pointer but didn't.

**cooper1200** · 05-13-2019

i know you must shake your head in disrepair at me i do appreciate your feed back
thanks
coop

**cooper1200** · 05-13-2019

now i get a warning saying initialization from incomparable pointer type.

Code:

void get_player_names(int num_of_players, Hand *p_player)
{
    int i, x, str_index = 0;
    char buff[2], str_temp[10], *p_str_temp = &str_temp;

    for (i = 0; i < num_of_players; i++)
    {
        printf("Please enter player %d's name: ", i + 1);
        x = 0;
        while (x != 1)
        {
            fgets(buff, sizeof(buff), stdin);
            if (!strcmp(buff, "\n"))
            {
                strcpy(p_str_temp[str_index], buff[0]);
                p_str_index++;
            }
            else
            {
                x = sscanf(str_temp, "%s", p_player[i].player_name);
                if (x != 1)
                {
                    printf("Incorrect Entry\n Please enter player %d's name: ", i + 1);
                    x = 0;
                }
            }
        }
    }
}

**laserlight** · 05-13-2019

Answer my questions in post #6.

**cooper1200** · 05-13-2019

the next line of the warning takes me to this "extern char *strcpy (char *__restrict __dest, const char *__restrict __src)" so a char pointer right?
coop

**cooper1200** · 05-13-2019

however, looking at the rest of that line by that logic it wants a pointer to the buff variable in my case which it isn't complaining about yet

**laserlight** · 05-13-2019

Yes, but that's only half the answer.

Look, I asked you to examine what was actually passed for a reason. You took one look at the expected argument type and jumped to a wrong conclusion.

Here's another one:

Code:

void foo(int *p){}

Given this:

Code:

int xs[] = {1, 2};

Which of the following is correct?

Code:

foo(xs[0]); // option A
foo(xs); // option B
foo(&xs); // option C

**cooper1200** · 05-13-2019

i honestly don't know. its one of the issues i really don't get i have used both b and c in the past and both have worked and option a and the only difference with option a is your passing a specific element
coop

**laserlight** · 05-13-2019

What is the type of the argument for each of the options?

**cooper1200** · 05-13-2019

an int

Thread: looking at the string of characters in buffer for fgets

Thread Tools

Search Thread

Display

looking at the string of characters in buffer for fgets

Similar Threads

Why is fgets not fully populating its buffer?

fgets skipping, buffer issue?

Excess buffer using fgets

fgets buffer

fgets(buffer,sizeof(buffer),stdin);

Tags for this Thread