warning assignment makes interger from pointer without cast

[cooper1200]

what is wrong with this function

void update_board_array(char board[][ROW_MAX + 1], char place_character[10], int x_coordinate, int y_coordinate)
{
    board[x_coordinate][y_coordinate] = (((y_coordinate % 2 == 0) && (x_coordinate % 2 == 0)) ||
                                         ((y_coordinate % 2 != 0) && (x_coordinate % 2 != 0))) ? place_character : INVALID_SQUARE;
}

both the board and the place_character are declared as type char and the x_coordinate and y_coordinate are declared as type int
many thanks
coop

[Salem]

place_character is an array, but you don't supply a subscript.

[cooper1200]

ok im obviously going about this the wrong way. i want to assign a string to place_character and with in the function above assign that string to board[x][y] ie

int main()
{
    char my_string[10] = "hello world", board[8][8];
    update_board_array(board, my_string,x,y);
}
void update_board_array(char board[][ROW_MAX + 1], char place_character[10], int x_coordinate, int y_coordinate)
{
    board[x_coordinate][y_coordinate] = (((y_coordinate % 2 == 0) && (x_coordinate % 2 == 0)) ||
                                         ((y_coordinate % 2 != 0) && (x_coordinate % 2 != 0))) ? place_character : INVALID_SQUARE;
}

only reason i want to do this is so i can highlight the piece selected when the board is refreshed
many thanks
coop

[cooper1200]

im a complete moron at times when i will get all this though my thick skull i just don't know

string[10] is 10 characters long not 10 words long right???????

if i want to store a string with in each element of a 8x8 array would i need a 3rd dimention ie an 8x8x10 would hold 64 lots of an array of 10 characters

is this right or am i still barking up the wrong tree

many thanks
coop

[cooper1200]

nope now whats wrong this was copied out of a book

int main()
{
    int i;//, j, k;
    char *movies[3] = {"batman",
                       "gone in 60 seconds",
                       "get carter"};


    for (i = 0; i < 3; i++)
    {
        printf("%s\n",*movies[i]);
    }
}

this is getting beyond a joke
coop

[Salem]

> char my_string[10] = "hello world", board[8][8];
> update_board_array(board, my_string,x,y);
Leaving aside the problem that "hello world" needs 12 characters to store it, what are you hoping to see in your 8x8 board.

Are you trying to create say a crossword puzzle?

[flp1969]

You've declared movies as an array of pointers to char:

char *movies[3] = {"batman",
                   "gone in 60 seconds",
                   "get carter"};

And trying to print individual chars (printf expects a pointer due to "%s") -- line 11:

printf("%s\n",*movies[i]);

The correct printf() call should be:

printf("%s\n", movies[i]);

[cooper1200]

a single character but i want the extra space so when i put in the co-ordinates of the character on the board i can use escape codes to colour it red to show it has been selected.
many thanks
coop

[Salem]

It seems like you'd be better off making the place_character a single char (not an array), then from main calling
update_board_array(board, my_string[0],x,y); // place 'H' somewhere.

[cooper1200]

am i trying to do the impossible here because no matter how many *'s i use or what way i word everything all i get is the same warning unless i set everything at deceleration which i cant do unless i declare 128 different strings and 64 different board arrays

[laserlight]

You need to start thinking of what the declarations and expressions mean then. Ask yourself, what is the type of this object? Ask yourself, what is the type of this expression?

[cooper1200]

thats just it if i declare char mystring[2][10]; for example then do a printf("%s", mystring[0][10]) where have i declared it as a type int?? and why do i get a warning abut %s expecting type char but argument 2 has type int

[laserlight]

What is the type of mystring[0][10]?

[cooper1200]

char as i declared it as char
yes????

[laserlight]

Yes, although note that you're accessing out of bounds, so it's actually mystring[1][0].

Now, %s expects a string argument, which effectively means a char*. A char is not a char*, so you have a mismatch. What you want is thus mystring[0].