Thread: Inserting a name to a linked list

I try to insert a name to a linked list but it doesn't work. Where do i make mistake?

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>


struct node{
        
        char *data;
        struct node* next;
};


struct node* start = NULL;
struct node* temp;
struct node* iter;






void addrecord() {
    char *name; 
printf(" Enter the name: ");
    scanf(" %s",name);
    struct node* newnode= (struct node*)malloc(sizeof(struct node));
    strcpy(newnode->data,name);
newnode->next = NULL;

if(start == NULL)
{
start = newnode;
}
else
{

temp = start;
while(temp->next != NULL)
{
temp = temp->next;

}

temp->next = newnode;
}

}

int main() {
    
    
    addrecord();

}

Originally Posted by Salem

You need to malloc space for newnode->data as well, before you copy.

how?

Line 25 is a crash. You declared a char* which, initially, points to an arbitrary memory location. You then pass it to scanf which will write to that location. Your compiler should be warning you about this, do not ignore compiler warnings. Similarly, on line 27 you strcpy into an uninitialized pointer in your node structure. Before you tackle data structures, you should go back an review pointers, arrays and memory allocation.

You're already using a malloc call for the structure - You are not checking to see if it worked before using it, or freeing it, but it is there

There is a quick tutorial on linked list here...
Linked Lists in C - Cprogramming.com

But if I were you, I'd be reading your course material for malloc - It's apparent that you don't appear to understand it.