Storing negative number in variables.

**Nand** · 04-04-2019

Code:

#include <stdio.h>
int main() {

    int count, input, temp, max;

printf("How many: ");
scanf("%d", &count);

printf("Enter %d inputs: ", count);
    for (int i = 0; i < count; ++i) {
        scanf("%d", &input);
        if(input > temp){
            max = input;
}
temp = input;
}

    printf("Max = %d", max);

    return 0;
}

I've wrote some code that enters 'x' amount of variables and determines which is the largest number to output. But I'm having issues with negative numbers and don't understand why.

for example: I input -2 -5 -10 and the output is 69.
All effort is appreciated.

Thanks,
Nand

**laserlight** · 04-04-2019

Why do you need the temp variable? It looks like you only need count, max, and input, and you need to set max to a suitable initial value (consider either setting max to the very first input, or #include <limits.h> and use something from there).

**Nand** · 04-04-2019

Originally Posted by laserlight

Why do you need the temp variable? It looks like you only need count, max, and input, and you need to set max to a suitable initial value (consider either setting max to the very first input, or #include <limits.h> and use something from there).

Thanks for the effort. It didn't help. The purpose of my code is to find the maximum input from any random user input of an integer.

**laserlight** · 04-04-2019

Yes, and that's why I gave you that advice. At the moment you're comparing input with temp, which initially wasn't given an initial value, so that first comparison is rubbish. You should be comparing input with max... but max also needs an initial value, hence my advice. If you wish to ignore my advice... your loss.

**Nand** · 04-04-2019

Fixed it, I understand what you are saying now. Sorry for the misunderstanding.

Code:

#include <stdio.h>
int main() {

int count, input, max;

printf("How many: ");
scanf("%d", &count);

printf("Enter %d inputs: ", count);
    for (int i = 0; i < count; ++i) {
        scanf("%d", &input);
        if(i == 0 || input > max){
            max = input;
}
    }

printf("Max = %d\n", max);

return 0;
}

Thread: Storing negative number in variables.

Thread Tools

Search Thread

Display

Storing negative number in variables.

Similar Threads

Read until negative number

Assigning negative number to unsigned variables.

How can i convert negative number to positive number ?

Storing Variables that come from a random number generator

random number between negative and positive number

Tags for this Thread