What's wrong here?

**hexdzn** · 03-09-2019

Hey, I have a C programming course and I am currently working on a problem that asks for:
Write a complete C program that will ask the user for a series of temperatures for a city. The value -99 will signify the end of entries. Have the program display the hottest temperature and also the coldest.

I have this as my code and whenever I try it on C it just results in asking me for 2 temperatures then ends. Please help!!

CODE:
insert

Code:

#include<stdio.h>


int
main(void)
{
    int temp, hottest, coldest;
    printf("Enter a temperature: ");
    scanf("%d", temp);
    temp = hottest;
    temp = coldest;
    while(temp != -99)
    {
        printf("Enter another temperature: ");
        scanf("%d", temp);
        
        if(temp>hottest)
        {
            temp = hottest;
            printf("The hottest temperature is %d", hottest);
        }
        else
        {
            printf("The hottest temperature is %d", hottest);
        }
        
        if(temp<coldest)
        {
            temp = coldest;
            printf("The hottest temperature is %d", coldest);
        }
        else
        {
            printf("The hottest temperature is %d", hottest);
        }
    }
    
    return(0);
}

**laserlight** · 03-09-2019

When using scanf to read an int, you need to pass a pointer as the corresponding argument, so in both cases you should have written:

Code:

scanf("%d", temp);

Also, recall that assignment with = assigns the right hand side to the left hand side. You're using it wrongly.

**hexdzn** · 03-09-2019

but they already say that no? Sorry I am terrible at programming lol

**laserlight** · 03-09-2019

Oh sorry. Forgot to modify to add the pointer:

Code:

scanf("%d", &temp);

**hexdzn** · 03-09-2019

thanks!

**hexdzn** · 03-09-2019

do you notice any other errors? It gives a weird number for the lowest and highest temperature.

**laserlight** · 03-09-2019

Yes, I wrote about it in my first post.

**Click_here** · 03-11-2019

Okay so...

If I want to give a variable a value, I do this...

Code:

banana = 4;

If I then want to give that value to another variable...

Code:

banana = 4;
apple = banana;

Have a closer look at

Code:

temp = hottest;

... The value in "temp" is lost, which is not what you want

Thread: What's wrong here?

Thread Tools

Search Thread

Display

What's wrong here?

Similar Threads

Why so wrong numbers? As I write so wrong?

What is wrong with my coding? Done but something's wrong somewhere.

wrong wrong with my xor function?

whats wrong with this? no errors but wrong result

Problem with input choice... Somethings wrong... really wrong....

Tags for this Thread