Thread: need help ...

hello for the input 5 5 my code is supposed to print this:


*****
* *
* *
* *
*****


but it prints:
*****
*****
*****
*****
*****
this is my code:

Code:

#include<stdio.h>
int main(){
int x,y;
int i,j,k,l;
char wall [x] [y];
scanf("%d %d",&x,&y);
for( i=0;i<x;i++){
for( j=0;j<y;j++){
if(i==0)
wall [i][j]='*';
else if(i==x-1)
wall [i] [j]='*';
else if(j==0)
wall [i] [j]=='*';
else if(j==y-1)
wall [i] [j]='*';
else 
wall [i][j]=' ' ;
}
}
for( k = 0 ; k < x; k++ ) {
for( l= 0 ; l < y ; l++ ) {
printf("%c", wall[k][l]);
}
printf("\n");
}
return 0;}

can you tell me what kind of mistake i make here thank you ...

Your indentation is non-existant.
Indentation style - Wikipedia

Your variable names are lousy.
Everything apart from i and j (your loop control variables) should have a meaningful name.
Like x is numRows, y is numCols.


> char wall [x] [y];
> scanf("%d %d",&x,&y);
Arrays don't magically resize just by assigning variables.